Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/sidebar/hooks/useRoomList.ts

Summary

Maintainability
D
2 days
Test Coverage

Function useRoomList has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useRoomList = (): Array<ISubscription & IRoom> => {
    const [roomList, setRoomList] = useDebouncedState<(ISubscription & IRoom)[]>([], 150);

    const showOmnichannel = useOmnichannelEnabled();
    const sidebarGroupByType = useUserPreference('sidebarGroupByType');
Severity: Major
Found in apps/meteor/client/sidebar/hooks/useRoomList.ts - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

                        return team.add(room);
    Severity: Major
    Found in apps/meteor/client/sidebar/hooks/useRoomList.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return showOmnichannel && onHold.add(room);
      Severity: Major
      Found in apps/meteor/client/sidebar/hooks/useRoomList.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return showOmnichannel && omnichannel.add(room);
        Severity: Major
        Found in apps/meteor/client/sidebar/hooks/useRoomList.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return discussion.add(room);
          Severity: Major
          Found in apps/meteor/client/sidebar/hooks/useRoomList.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        rooms.forEach((room) => {
                if (room.archived) {
                    return;
                }
            Severity: Major
            Found in apps/meteor/client/sidebar/hooks/useRoomList.ts and 1 other location - About 1 day to fix
            apps/meteor/client/sidebarv2/hooks/useRoomList.ts on lines 50..92

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 340.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status