RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/account/profile/AccountProfileForm.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function AccountProfileForm has 280 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const AccountProfileForm = (props: AllHTMLAttributes<HTMLFormElement>): ReactElement => {
    const t = useTranslation();
    const user = useUser();
    const dispatchToastMessage = useToastMessageDispatch();

Severity: Major
Found in apps/meteor/client/views/account/profile/AccountProfileForm.tsx - About 1 day to fix

    File AccountProfileForm.tsx has 319 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import type { IUser } from '@rocket.chat/core-typings';
    import {
        Field,
        FieldGroup,
        FieldLabel,
    Severity: Minor
    Found in apps/meteor/client/views/account/profile/AccountProfileForm.tsx - About 3 hrs to fix

      Function AccountProfileForm has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      const AccountProfileForm = (props: AllHTMLAttributes<HTMLFormElement>): ReactElement => {
          const t = useTranslation();
          const user = useUser();
          const dispatchToastMessage = useToastMessageDispatch();
      
      
      Severity: Minor
      Found in apps/meteor/client/views/account/profile/AccountProfileForm.tsx - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <Field>
                          <FieldLabel htmlFor={nicknameId}>{t('Nickname')}</FieldLabel>
                          <FieldRow>
                              <Controller
                                  control={control}
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 328..339

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 139.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 20 locations. Consider refactoring.
      Open

                              {errors?.username && (
                                  <FieldError aria-live='assertive' id={`${usernameId}-error`}>
                                      {errors.username.message}
                                  </FieldError>
                              )}
      apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 191..195
      apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 294..298
      apps/meteor/client/views/account/security/ChangePassword.tsx on lines 74..78
      apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 219..223
      apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 173..177
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 204..208
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 230..234
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 259..263
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 295..299
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 322..326
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 363..367
      apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 130..134
      apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 156..160
      apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx on lines 190..194
      apps/meteor/ee/client/omnichannel/additionalForms/BusinessHoursMultiple.tsx on lines 51..55
      apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 58..62
      apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 94..98
      packages/web-ui-registration/src/RegisterForm.tsx on lines 228..232
      packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx on lines 111..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 20 locations. Consider refactoring.
      Open

                          {errors?.bio && (
                              <FieldError aria-live='assertive' id={`${bioId}-error`}>
                                  {errors.bio.message}
                              </FieldError>
                          )}
      apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 191..195
      apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 216..220
      apps/meteor/client/views/account/security/ChangePassword.tsx on lines 74..78
      apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 219..223
      apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 173..177
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 204..208
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 230..234
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 259..263
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 295..299
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 322..326
      apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 363..367
      apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 130..134
      apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 156..160
      apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx on lines 190..194
      apps/meteor/ee/client/omnichannel/additionalForms/BusinessHoursMultiple.tsx on lines 51..55
      apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 58..62
      apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 94..98
      packages/web-ui-registration/src/RegisterForm.tsx on lines 228..232
      packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx on lines 111..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

                              {errors.name && (
                                  <FieldError aria-live='assertive' id={`${nameId}-error`}>
                                      {errors.name.message}
                                  </FieldError>
                              )}
      apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 142..146
      apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 169..173
      apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 233..237
      apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 78..82
      apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
      apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
      apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
      apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
      apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
      packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
      packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
      packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
      packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
      packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
      packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
      packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
      packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

                          {errors?.statusText && (
                              <FieldError aria-live='assertive' id={`${statusTextId}-error`}>
                                  {errors?.statusText.message}
                              </FieldError>
                          )}
      apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 190..194
      apps/meteor/client/views/admin/integrations/outgoing/OutgoingWebhookForm.tsx on lines 259..263
      apps/meteor/client/views/admin/integrations/outgoing/OutgoingWebhookForm.tsx on lines 298..302
      apps/meteor/client/views/admin/integrations/outgoing/OutgoingWebhookForm.tsx on lines 383..387
      apps/meteor/ee/client/omnichannel/tags/TagEdit.tsx on lines 95..99
      apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 184..188
      apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 252..256
      apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 292..296

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          const handleSave = async ({ email, name, username, statusType, statusText, nickname, bio, customFields }: AccountProfileFormValues) => {
              try {
                  await updateOwnBasicInfo(
                      {
                          realname: name,
      apps/meteor/app/discussion/server/methods/createDiscussion.ts on lines 68..197
      apps/meteor/client/components/message/content/UrlPreviews.tsx on lines 70..80
      apps/meteor/client/components/message/content/attachments/file/GenericFileAttachment.tsx on lines 23..71
      apps/meteor/client/components/message/content/urlPreviews/OEmbedPreviewContent.tsx on lines 16..49
      apps/meteor/client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTable.tsx on lines 26..94
      apps/meteor/client/views/room/composer/ComposerBoxPopupUser.tsx on lines 21..60
      apps/meteor/client/views/room/contextualBar/RoomMembers/RoomMembersItem.tsx on lines 30..60
      packages/livechat/src/components/uiKit/message/ButtonElement/index.tsx on lines 17..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  reset({ email, name, username, statusType, statusText, nickname, bio, customFields });
      apps/meteor/app/discussion/server/methods/createDiscussion.ts on lines 234..234
      apps/meteor/app/lib/server/functions/sendMessage.ts on lines 90..99
      apps/meteor/client/views/omnichannel/webhooks/WebhooksPage.tsx on lines 68..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const {
              allowRealNameChange,
              allowUserStatusMessageChange,
              allowEmailChange,
              allowUserAvatarChange,
      Severity: Minor
      Found in apps/meteor/client/views/account/profile/AccountProfileForm.tsx and 1 other location - About 35 mins to fix
      apps/meteor/client/views/setupWizard/steps/RegisterServerStep.tsx on lines 18..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status