Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function AccountTokensTable has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const AccountTokensTable = (): ReactElement => {
    const t = useTranslation();
    const dispatchToastMessage = useToastMessageDispatch();
    const setModal = useSetModal();
    const userId = useUserId();
Severity: Major
Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx - About 5 hrs to fix

    Function AccountTokensTable has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    const AccountTokensTable = (): ReactElement => {
    const t = useTranslation();
    const dispatchToastMessage = useToastMessageDispatch();
    const setModal = useSetModal();
    const userId = useUserId();
    Severity: Minor
    Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleRegenerate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            (name) => {
            const onConfirm: () => Promise<void> = async () => {
                try {
                    setModal(null);
                    const token = await regenerateToken({ tokenName: name });
    Severity: Minor
    Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (phase === AsyncStatePhase.REJECTED) {
        return (
            <Box display='flex' justifyContent='center' alignItems='center' height='100%'>
                <States>
                    <StatesIcon name='warning' variation='danger' />
      Severity: Major
      Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx and 1 other location - About 6 hrs to fix
      apps/meteor/client/components/deviceManagement/DeviceManagementTable/DeviceManagementTable.tsx on lines 42..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  setModal(
                <GenericModal
                    variant='warning'
                    confirmText={t('API_Personal_Access_Tokens_Regenerate_It')}
                    onConfirm={onConfirm}
      Severity: Major
      Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx and 1 other location - About 1 hr to fix
      apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx on lines 114..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  setModal(
                <GenericModal variant='danger' confirmText={t('Remove')} onConfirm={onConfirm} onCancel={closeModal} onClose={closeModal}>
                    {t('API_Personal_Access_Tokens_Remove_Modal')}
                </GenericModal>,
            );
      Severity: Major
      Found in apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx and 1 other location - About 1 hr to fix
      apps/meteor/client/views/account/tokens/AccountTokensTable/AccountTokensTable.tsx on lines 86..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status