Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/admin/import/NewImportPage.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function NewImportPage has 256 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function NewImportPage() {
    const t = useTranslation();
    const dispatchToastMessage = useToastMessageDispatch();
    const handleError = useErrorHandler();
Severity: Major
Found in apps/meteor/client/views/admin/import/NewImportPage.tsx - About 1 day to fix

    Function NewImportPage has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    function NewImportPage() {
    const t = useTranslation();
    const dispatchToastMessage = useToastMessageDispatch();
    const handleError = useErrorHandler();
    Severity: Minor
    Found in apps/meteor/client/views/admin/import/NewImportPage.tsx - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File NewImportPage.tsx has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Box, Button, ButtonGroup, Callout, Chip, Field, Margins, Select, InputBox, TextInput, UrlInput } from '@rocket.chat/fuselage';
import { useUniqueId, useSafely } from '@rocket.chat/fuselage-hooks';
import type { TranslationKey } from '@rocket.chat/ui-contexts';
import { useToastMessageDispatch, useRouter, useRouteParameter, useSetting, useEndpoint, useTranslation } from '@rocket.chat/ui-contexts';
import { useQuery } from '@tanstack/react-query';
    Severity: Minor
    Found in apps/meteor/client/views/admin/import/NewImportPage.tsx - About 2 hrs to fix

      Function handleFileUploadImportButtonClick has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const handleFileUploadImportButtonClick = async () => {
        if (!importerKey) {
            return;
        }
      Severity: Minor
      Found in apps/meteor/client/views/admin/import/NewImportPage.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const handleFileUrlImportButtonClick = async () => {
        if (!importerKey) {
            return;
        }
        Severity: Major
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 4 hrs to fix
        apps/meteor/client/views/admin/import/NewImportPage.tsx on lines 159..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const handleFilePathImportButtonClick = async () => {
        if (!importerKey) {
            return;
        }
        Severity: Major
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 4 hrs to fix
        apps/meteor/client/views/admin/import/NewImportPage.tsx on lines 135..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                        {fileType === 'url' && (
                                    <Field>
                                        <Field.Label alignSelf='stretch' htmlFor={fileSourceInputId}>
                                            {t('File_URL')}
                                        </Field.Label>
        Severity: Major
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 3 hrs to fix
        apps/meteor/client/views/admin/import/NewImportPage.tsx on lines 287..296

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                        {fileType === 'path' && (
                                    <Field>
                                        <Field.Label alignSelf='stretch' htmlFor={fileSourceInputId}>
                                            {t('File_Path')}
                                        </Field.Label>
        Severity: Major
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 3 hrs to fix
        apps/meteor/client/views/admin/import/NewImportPage.tsx on lines 277..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const isDataTransferEvent = <T extends SyntheticEvent>(event: T): event is T & DragEvent<HTMLInputElement> =>
        Boolean('dataTransfer' in event && (event as any).dataTransfer.files);
        Severity: Major
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 1 hr to fix
        apps/meteor/client/views/admin/settings/inputs/AssetSettingInput.tsx on lines 22..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!files || files.length === 0) {
            if (isDataTransferEvent(event)) {
                files = event.dataTransfer.files;
            }
        }
        Severity: Minor
        Found in apps/meteor/client/views/admin/import/NewImportPage.tsx and 1 other location - About 35 mins to fix
        apps/meteor/client/views/admin/settings/inputs/AssetSettingInput.tsx on lines 28..32

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status