Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/admin/rooms/EditRoom.tsx

Summary

Maintainability
F
3 days
Test Coverage

File EditRoom.tsx has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IRoom, RoomAdminFieldsType } from '@rocket.chat/core-typings';
import { isRoomFederated } from '@rocket.chat/core-typings';
import {
    Box,
    Button,
Severity: Minor
Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx - About 4 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                                <Field>
                                <FieldRow>
                                    <FieldLabel htmlFor={archivedField}>{t('Room_archivation_state_true')}</FieldLabel>
                                    <Controller
                                        name='archived'
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 2 other locations - About 5 hrs to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 308..319
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 332..343

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <Field>
                    <FieldRow>
                        <FieldLabel htmlFor={featuredField}>{t('Featured')}</FieldLabel>
                        <Controller
                            name='featured'
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 2 other locations - About 5 hrs to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 293..304
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 308..319

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <Field>
                    <FieldRow>
                        <FieldLabel htmlFor={isDefaultField}>{t('Default')}</FieldLabel>
                        <Controller
                            name='isDefault'
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 2 other locations - About 5 hrs to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 293..304
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 332..343

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            {canViewAnnouncement && (
                            <Field>
                                <FieldLabel htmlFor={roomAnnouncement}>{t('Announcement')}</FieldLabel>
                                <FieldRow>
                                    <Controller
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 1 other location - About 4 hrs to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 189..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            {canViewDescription && (
                            <Field>
                                <FieldLabel htmlFor={roomDescription}>{t('Description')}</FieldLabel>
                                <FieldRow>
                                    <Controller
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 1 other location - About 4 hrs to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 203..216

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

                        {errors?.roomName && (
                        <FieldError aria-live='assertive' id={`${roomNameField}-error`}>
                            {errors.roomName.message}
                        </FieldError>
                    )}
    Severity: Major
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 19 other locations - About 1 hr to fix
    apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 191..195
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 216..220
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 294..298
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 74..78
    apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 219..223
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 204..208
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 230..234
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 259..263
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 295..299
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 322..326
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 363..367
    apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 130..134
    apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 156..160
    apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx on lines 190..194
    apps/meteor/ee/client/omnichannel/additionalForms/BusinessHoursMultiple.tsx on lines 51..55
    apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 58..62
    apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 94..98
    packages/web-ui-registration/src/RegisterForm.tsx on lines 228..232
    packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx on lines 111..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const handleSave = useEffectEvent((data) =>
        Promise.all([isDirty && handleUpdateRoomData(data), changeArchiving && handleArchive()].filter(Boolean)),
    );
    Severity: Minor
    Found in apps/meteor/client/views/admin/rooms/EditRoom.tsx and 1 other location - About 40 mins to fix
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 152..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status