RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function dateRangeReducer has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const dateRangeReducer = (state: DateRange, action: DateRangeAction): DateRange => {
    switch (action) {
        case 'today': {
            return {
                start: moment().startOf('day').toDate(),
Severity: Major
Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 2 hrs to fix

    Function dateRangeReducer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    const dateRangeReducer = (state: DateRange, action: DateRangeAction): DateRange => {
        switch (action) {
            case 'today': {
                return {
                    start: moment().startOf('day').toDate(),
    Severity: Minor
    Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return {
                    start: moment().subtract(1, 'month').startOf('month').toDate(),
                    end: moment().subtract(1, 'month').endOf('month').toDate(),
                };
    Severity: Major
    Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return state;
      Severity: Major
      Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return state;
        Severity: Major
        Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {
                          start: moment().startOf('month').toDate(),
                          end: moment().endOf('day').toDate(),
                      };
          Severity: Major
          Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return { ...state, end: parseFromEndDateInput(action.newEnd) };
            Severity: Major
            Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return { ...state, start: parseFromStartDateInput(action.newStart) };
              Severity: Major
              Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return newState;
                Severity: Major
                Found in apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'yesterday': {
                              return {
                                  start: moment().subtract(1, 'day').startOf('day').toDate(),
                                  end: moment().subtract(1, 'day').endOf('day').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 71..76
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 85..90

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'last-week': {
                              return {
                                  start: moment().subtract(1, 'week').startOf('week').toDate(),
                                  end: moment().subtract(1, 'week').endOf('week').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 57..62
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 85..90

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'last-month': {
                              return {
                                  start: moment().subtract(1, 'month').startOf('month').toDate(),
                                  end: moment().subtract(1, 'month').endOf('month').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 57..62
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 71..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 75.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if (typeof action === 'object' && 'newStart' in action) {
                                  if (action.newStart === formatToDateInput(state.start)) {
                                      return state;
                                  }
                  
                  
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 101..107

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if (typeof action === 'object' && 'newEnd' in action) {
                                  if (action.newEnd === formatToDateInput(state.end)) {
                                      return state;
                                  }
                  
                  
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 93..99

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'this-month': {
                              return {
                                  start: moment().startOf('month').toDate(),
                                  end: moment().endOf('day').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 50..55
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 64..69

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'today': {
                              return {
                                  start: moment().startOf('day').toDate(),
                                  end: moment().endOf('day').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 64..69
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 78..83

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          case 'this-week': {
                              return {
                                  start: moment().startOf('week').toDate(),
                                  end: moment().endOf('day').toDate(),
                              };
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 50..55
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 78..83

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  const parseFromEndDateInput = (date: string) => {
                      if (!date) {
                          return undefined;
                      }
                  
                  
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 21..27

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  const parseFromStartDateInput = (date: string) => {
                      if (!date) {
                          return undefined;
                      }
                  
                  
                  apps/meteor/client/views/audit/components/forms/DateRangePicker.tsx on lines 29..35

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status