Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx

Summary

Maintainability
F
5 days
Test Coverage

Function useAppMenu has 364 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useAppMenu = (app: App, isAppDetailsPage: boolean) => {
    const t = useTranslation();
    const router = useRouter();
    const setModal = useSetModal();
    const dispatchToastMessage = useToastMessageDispatch();
Severity: Major
Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 1 day to fix

    Function useAppMenu has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

    export const useAppMenu = (app: App, isAppDetailsPage: boolean) => {
    const t = useTranslation();
    const router = useRouter();
    const setModal = useSetModal();
    const dispatchToastMessage = useToastMessageDispatch();
    Severity: Minor
    Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File useAppMenu.tsx has 405 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { AppStatus } from '@rocket.chat/apps-engine/definition/AppStatus';
import type { App } from '@rocket.chat/core-typings';
import { Box, Icon } from '@rocket.chat/fuselage';
import {
    useSetModal,
    Severity: Minor
    Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 5 hrs to fix

      Function menuSections has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const menuSections = useMemo(() => {
        const bothAppStatusOptions = [
            canAppBeSubscribed &&
                isSubscribed &&
                isAdminUser && {
      Severity: Major
      Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 4 hrs to fix

        Function handleUninstall has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const handleUninstall = useCallback(() => {
        const uninstall = async () => {
            closeModal();
            try {
                const { success } = await uninstallApp();
        Severity: Major
        Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 2 hrs to fix

          Avoid too many return statements within this function.
          Open

                      return 'card';
          Severity: Major
          Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        app.installed &&
                isAdminUser &&
                isAppEnabled && {
                    id: 'disable',
                    section: 0,
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 398..409

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        app.installed &&
                isAdminUser && {
                    id: 'uninstall',
                    section: 1,
                    content: (
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 373..385

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        isAdminUser &&
                !!canUpdate &&
                !isAppDetailsPage && {
                    id: 'update',
                    section: 0,
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 307..319

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        canAppBeSubscribed &&
                isSubscribed &&
                isAdminUser && {
                    id: 'subscribe',
                    section: 0,
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 360..372

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
            const { status } = await setAppStatus({ status: AppStatus.MANUALLY_ENABLED });
            warnEnableDisableApp(app.name, status, 'enable');
        } catch (error) {
            handleAPIError(error);
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 172..177

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        try {
                const { status } = await setAppStatus({ status: AppStatus.MANUALLY_DISABLED });
                warnEnableDisableApp(app.name, status, 'disable');
            } catch (error) {
                handleAPIError(error);
            Severity: Major
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 1 hr to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 185..190

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    setModal(
            <WarningModal close={closeModal} confirm={uninstall} text={t('Apps_Marketplace_Uninstall_App_Prompt')} confirmText={t('Yes')} />,
        );
            Severity: Minor
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 40 mins to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 179..181

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    setModal(
            <WarningModal close={closeModal} confirm={confirm} text={t('Apps_Marketplace_Deactivate_App_Prompt')} confirmText={t('Yes')} />,
        );
            Severity: Minor
            Found in apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx and 1 other location - About 40 mins to fix
            apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx on lines 249..251

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status