RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/omnichannel/triggers/TriggersTable.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function TriggersTable has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const TriggersTable = () => {
    const t = useTranslation();
    const router = useRouter();

    const handleAddNew = useMutableCallback(() => {
Severity: Major
Found in apps/meteor/client/views/omnichannel/triggers/TriggersTable.tsx - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                {isSuccess && data.triggers.length === 0 && !queryHasChanged && (
                    <GenericNoResults
                        icon='smart'
                        title={t('No_triggers_yet')}
                        description={t('No_triggers_yet_description')}
    apps/meteor/client/views/omnichannel/customFields/CustomFieldsTable.tsx on lines 88..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 24 locations. Consider refactoring.
    Open

                {isLoading && (
                    <GenericTable>
                        <GenericTableHeader>{headers}</GenericTableHeader>
                        <GenericTableBody>
                            <GenericTableLoadingRow cols={4} />
    apps/meteor/client/omnichannel/businessHours/BusinessHoursTable.tsx on lines 51..58
    apps/meteor/client/omnichannel/cannedResponses/CannedResponsesTable.tsx on lines 128..135
    apps/meteor/client/omnichannel/monitors/MonitorsTable.tsx on lines 148..155
    apps/meteor/client/omnichannel/priorities/PrioritiesTable.tsx on lines 38..45
    apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx on lines 88..95
    apps/meteor/client/omnichannel/tags/TagsTable.tsx on lines 74..81
    apps/meteor/client/views/admin/customEmoji/CustomEmoji.tsx on lines 70..77
    apps/meteor/client/views/admin/customSounds/CustomSoundsTable/CustomSoundsTable.tsx on lines 68..75
    apps/meteor/client/views/admin/invites/InvitesPage.tsx on lines 94..101
    apps/meteor/client/views/admin/oauthApps/OAuthAppsTable.tsx on lines 51..58
    apps/meteor/client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTable.tsx on lines 91..98
    apps/meteor/client/views/admin/settings/groups/VoipGroupPage/VoipExtensionsPage.tsx on lines 70..77
    apps/meteor/client/views/audit/components/AuditLogTable.tsx on lines 63..70
    apps/meteor/client/views/directory/tabs/channels/ChannelsTable/ChannelsTable.tsx on lines 100..107
    apps/meteor/client/views/directory/tabs/teams/TeamsTable/TeamsTable.tsx on lines 77..84
    apps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsx on lines 99..106
    apps/meteor/client/views/omnichannel/currentChats/CurrentChatsPage.tsx on lines 331..338
    apps/meteor/client/views/omnichannel/customFields/CustomFieldsTable.tsx on lines 79..86
    apps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentsTable.tsx on lines 95..102
    apps/meteor/client/views/omnichannel/directory/calls/CallTable.tsx on lines 99..106
    apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx on lines 138..145
    apps/meteor/client/views/omnichannel/directory/contacts/ContactTable.tsx on lines 115..122
    apps/meteor/client/views/omnichannel/queueList/QueueListTable.tsx on lines 117..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 19 locations. Consider refactoring.
    Open

                        <Pagination
                            divider
                            current={current}
                            itemsPerPage={itemsPerPage}
                            count={data?.total || 0}
    apps/meteor/client/components/deviceManagement/DeviceManagementTable/DeviceManagementTable.tsx on lines 69..77
    apps/meteor/client/omnichannel/cannedResponses/CannedResponsesTable.tsx on lines 188..196
    apps/meteor/client/omnichannel/monitors/MonitorsTable.tsx on lines 183..191
    apps/meteor/client/omnichannel/slaPolicies/SlaTable.tsx on lines 125..133
    apps/meteor/client/omnichannel/tags/TagsTable.tsx on lines 118..126
    apps/meteor/client/omnichannel/units/UnitsTable.tsx on lines 118..126
    apps/meteor/client/views/admin/customEmoji/CustomEmoji.tsx on lines 104..112
    apps/meteor/client/views/admin/integrations/IntegrationsTable.tsx on lines 119..127
    apps/meteor/client/views/admin/rooms/RoomsTable.tsx on lines 142..150
    apps/meteor/client/views/admin/settings/groups/VoipGroupPage/VoipExtensionsPage.tsx on lines 126..134
    apps/meteor/client/views/directory/tabs/channels/ChannelsTable/ChannelsTable.tsx on lines 118..126
    apps/meteor/client/views/directory/tabs/teams/TeamsTable/TeamsTable.tsx on lines 100..108
    apps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsx on lines 124..132
    apps/meteor/client/views/omnichannel/agents/AgentsTable/AgentsTable.tsx on lines 105..113
    apps/meteor/client/views/omnichannel/departments/DepartmentsTable/DepartmentsTable.tsx on lines 134..142
    apps/meteor/client/views/omnichannel/directory/calls/CallTable.tsx on lines 127..135
    apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx on lines 162..170
    apps/meteor/client/views/omnichannel/queueList/QueueListTable.tsx on lines 148..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                {data.triggers.map(({ _id, name, description, enabled }) => (
                                    <TriggersRow key={_id} _id={_id} name={name} description={description} enabled={enabled} reload={refetch} />
                                ))}
    Severity: Minor
    Found in apps/meteor/client/views/omnichannel/triggers/TriggersTable.tsx and 1 other location - About 45 mins to fix
    apps/meteor/client/views/admin/users/AdminUserInfoActions.tsx on lines 135..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        const { data, refetch, isSuccess, isLoading, isError } = useQuery(['livechat-triggers', query], async () => getTriggers(query));
    apps/meteor/client/omnichannel/businessHours/BusinessHoursTable.tsx on lines 34..36
    apps/meteor/client/views/admin/customEmoji/CustomEmoji.tsx on lines 61..61
    apps/meteor/client/views/admin/integrations/IntegrationsTable.tsx on lines 44..44
    apps/meteor/client/views/directory/tabs/channels/ChannelsTable/ChannelsTable.tsx on lines 86..86
    apps/meteor/client/views/directory/tabs/teams/TeamsTable/TeamsTable.tsx on lines 63..63
    apps/meteor/client/views/directory/tabs/users/UsersTable/UsersTable.tsx on lines 85..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status