Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function useQuickActions has 285 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useQuickActions = (): {
    quickActions: QuickActionsActionConfig[];
    actionDefault: (actionId: string) => void;
} => {
    const room = useOmnichannelRoom();
Severity: Major
Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx - About 1 day to fix

    Function useQuickActions has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

    export const useQuickActions = (): {
    quickActions: QuickActionsActionConfig[];
    actionDefault: (actionId: string) => void;
} => {
    const room = useOmnichannelRoom();
    Severity: Minor
    Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File useQuickActions.tsx has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { useMutableCallback } from '@rocket.chat/fuselage-hooks';
import {
    useSetModal,
    useToastMessageDispatch,
    useUserId,
    Severity: Minor
    Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx - About 3 hrs to fix

      Function handleAction has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const handleAction = useMutableCallback(async (id: string) => {
        switch (id) {
            case QuickActionsEnum.MoveQueue:
                setModal(
                    <ReturnChatQueueModal
      Severity: Major
      Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx - About 2 hrs to fix

        Function handleForwardChat has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                async (departmentId?: string, userId?: string, comment?: string) => {
            if (departmentId && userId) {
                return;
            }
            const transferData: {
        Severity: Minor
        Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            await discardTranscript();
            dispatchToastMessage({
                type: 'success',
                message: t('Livechat_transcript_request_has_been_canceled'),
          Severity: Major
          Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx and 1 other location - About 1 hr to fix
          apps/meteor/client/views/omnichannel/triggers/TriggersRow.tsx on lines 37..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  try {
            await sendTranscriptPDF();
            dispatchToastMessage({
                type: 'success',
                message: t('Livechat_transcript_has_been_requested'),
          Severity: Major
          Found in apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx and 4 other locations - About 1 hr to fix
          apps/meteor/client/views/account/profile/AccountProfilePage.tsx on lines 54..62
          apps/meteor/client/views/admin/emailInbox/SendTestButton.tsx on lines 18..29
          apps/meteor/client/views/admin/settings/groups/OAuthGroupPage.tsx on lines 41..46
          apps/meteor/client/views/omnichannel/currentChats/RemoveChatButton.tsx on lines 24..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status