Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

it('should return false if both messages are not from the same thread', () => {
    const previous: IMessage = {
        ...baseMessage,
        tmid: 'threadId',
    };
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 3 other locations - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 90..100
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 114..124
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 125..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

it("should return false if both messages don't have the same alias", () => {
    const previous: IMessage = {
        ...baseMessage,
        alias: 'alias',
    };
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 3 other locations - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 78..88
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 90..100
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 114..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

it('should return true if both messages are from the same thread same user and bellow the time range', () => {
    const previous: IMessage = {
        ...baseMessage,
        tmid: 'threadId',
    };
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 3 other locations - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 78..88
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 114..124
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 125..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

it('should return true if message is a reply from a previous message', () => {
    const previous: IMessage = {
        ...baseMessage,
        _id: 'threadId',
    };
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 3 other locations - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 78..88
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 90..100
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 125..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it('should return false if both messages belongs to the same user but have more than five minutes of difference', () => {
    const previous: IMessage = {
        ...baseMessage,
    };
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 57..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

it('should return true if both messages belongs to the same user and have less than five minutes of difference', () => {
    const previous: IMessage = {
        ...baseMessage,
    };
    const current: IMessage = {
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts on lines 45..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

const baseMessage: IMessage = {
    ts: date,
    u: {
        _id: 'userId',
        name: 'userName',
Severity: Major
Found in apps/meteor/client/views/room/MessageList/lib/isMessageSequential.spec.ts and 2 other locations - About 1 hr to fix
apps/meteor/client/lib/parseMessageTextToAstMarkdown.spec.ts on lines 112..124
apps/meteor/client/views/room/MessageList/lib/isMessageNewDay.spec.ts on lines 7..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status