RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts

Summary

Maintainability
F
4 days
Test Coverage

Function useComposerBoxPopup has a Cognitive Complexity of 78 (exceeds 5 allowed). Consider refactoring.
Open

export const useComposerBoxPopup = <T extends { _id: string; sort?: number }>({
    configurations,
}: {
    configurations: ComposerBoxPopupOptions<T>[];
}): ComposerBoxPopupResult<T> => {
Severity: Minor
Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function keydown has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const keydown = useMutableCallback((event: KeyboardEvent) => {
        if (!popup) {
            return;
        }

Severity: Minor
Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if (event.which === keys.ARROW_DOWN && !(event.shiftKey || event.ctrlKey || event.altKey || event.metaKey)) {
                setFocused((focused) => {
                    const list = items
                        .filter((item) => item.isSuccess)
                        .flatMap((item) => item.data as T[])
    Severity: Critical
    Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (event.which === keys.ARROW_UP && !(event.shiftKey || event.ctrlKey || event.altKey || event.metaKey)) {
                  setFocused((focused) => {
                      const list = items
                          .filter((item) => item.isSuccess)
                          .flatMap((item) => item.data as T[])
      Severity: Critical
      Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 1 hr to fix

        Function setConfigByInput has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const setConfigByInput = useMutableCallback((): ComposerBoxPopupOptions<T> | undefined => {
                const value = chat?.composer?.substring(0, chat?.composer?.selection.start);
        
                if (!value) {
                    setPopup(undefined);
        Severity: Minor
        Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                      return true;
          Severity: Major
          Found in apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        const sortedItems = items
                            .filter((item) => item.isSuccess)
                            .flatMap((item) => item.data as T[])
                            .sort((a, b) => (('sort' in a && a.sort) || 0) - (('sort' in b && b.sort) || 0));
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 200..203
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 219..222

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            const list = items
                                .filter((item) => item.isSuccess)
                                .flatMap((item) => item.data as T[])
                                .sort((a, b) => (('sort' in a && a.sort) || 0) - (('sort' in b && b.sort) || 0));
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 86..89
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 200..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            const list = items
                                .filter((item) => item.isSuccess)
                                .flatMap((item) => item.data as T[])
                                .sort((a, b) => (('sort' in a && a.sort) || 0) - (('sort' in b && b.sort) || 0));
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 86..89
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 219..222

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        const selector =
                            popup.matchSelectorRegex ??
                            (popup.triggerAnywhere ? new RegExp(`(?:^| |\n)(${popup.trigger})([^\\s]*$)`) : new RegExp(`(?:^)(${popup.trigger})([^\\s]*$)`));
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 147..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        const selector =
                            configuration.matchSelectorRegex ??
                            (configuration.triggerAnywhere
                                ? new RegExp(`(?:^| |\n)(${configuration.trigger})([^\\s]*$)`)
                                : new RegExp(`(?:^)(${configuration.trigger})([^\\s]*$)`));
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 103..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                return {
                    focused,
                    items,
                    ariaActiveDescendant,
                    popup,
            apps/meteor/ee/server/apps/communication/uikit.ts on lines 122..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (event.which === keys.ARROW_DOWN && !(event.shiftKey || event.ctrlKey || event.altKey || event.metaKey)) {
                        setFocused((focused) => {
                            const list = items
                                .filter((item) => item.isSuccess)
                                .flatMap((item) => item.data as T[])
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 198..216

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (event.which === keys.ARROW_UP && !(event.shiftKey || event.ctrlKey || event.altKey || event.metaKey)) {
                        setFocused((focused) => {
                            const list = items
                                .filter((item) => item.isSuccess)
                                .flatMap((item) => item.data as T[])
            apps/meteor/client/views/room/composer/hooks/useComposerBoxPopup.ts on lines 217..235

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status