RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function MessageBox has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Open

const MessageBox = ({
    tmid,
    onSend,
    onJoin,
    onNavigateToNextMessage,
Severity: Minor
Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MessageBox.tsx has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable complexity */
import type { IMessage, ISubscription } from '@rocket.chat/core-typings';
import { useContentBoxSize, useMutableCallback } from '@rocket.chat/fuselage-hooks';
import {
    MessageComposerAction,
Severity: Minor
Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 5 hrs to fix

    Function handler has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const handler: KeyboardEventHandler<HTMLTextAreaElement> = useMutableCallback((event) => {
            const { which: keyCode } = event;
    
            const input = event.target as HTMLTextAreaElement;
    
    
    Severity: Minor
    Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 1 hr to fix

      Function handlePaste has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const handlePaste: ClipboardEventHandler<HTMLTextAreaElement> = useMutableCallback((event) => {
              const { clipboardData } = event;
      
              if (!clipboardData) {
                  return;
      Severity: Minor
      Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                if (isSubmitKey) {
                    const withModifier = event.shiftKey || event.ctrlKey || event.altKey || event.metaKey;
                    const isSending = (sendOnEnter && !withModifier) || (!sendOnEnter && withModifier);
        
                    event.preventDefault();
        Severity: Major
        Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 1 hr to fix

          Function handleFormattingShortcut has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          const handleFormattingShortcut = (
              event: KeyboardEvent<HTMLTextAreaElement>,
              formattingButtons: FormattingButton[],
              composer: ComposerAPI,
          ) => {
          Severity: Minor
          Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                          return;
          Severity: Major
          Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return;
            Severity: Major
            Found in apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx - About 30 mins to fix

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  const isRecordingAudio = useSubscription({
                      getCurrentValue: chat.composer?.recording.get ?? getEmptyFalse,
                      subscribe: chat.composer?.recording.subscribe ?? emptySubscribe,
                  });
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 262..265
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 272..275
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 277..280
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  const formatters = useSubscription({
                      getCurrentValue: chat.composer?.formatters.get ?? getEmptyArray,
                      subscribe: chat.composer?.formatters.subscribe ?? emptySubscribe,
                  });
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 262..265
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 267..270
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 272..275
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 277..280

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  const isEditing = useSubscription({
                      getCurrentValue: chat.composer?.editing.get ?? getEmptyFalse,
                      subscribe: chat.composer?.editing.subscribe ?? emptySubscribe,
                  });
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 267..270
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 272..275
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 277..280
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  const isMicrophoneDenied = useSubscription({
                      getCurrentValue: chat.composer?.isMicrophoneDenied.get ?? getEmptyFalse,
                      subscribe: chat.composer?.isMicrophoneDenied.subscribe ?? emptySubscribe,
                  });
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 262..265
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 267..270
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 277..280
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  const isRecordingVideo = useSubscription({
                      getCurrentValue: chat.composer?.recordingVideo.get ?? getEmptyFalse,
                      subscribe: chat.composer?.recordingVideo.subscribe ?? emptySubscribe,
                  });
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 262..265
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 267..270
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 272..275
              apps/meteor/client/views/room/composer/messageBox/MessageBox.tsx on lines 282..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  const {
                      popup,
                      focused,
                      items,
                      ariaActiveDescendant,
              apps/meteor/client/views/composer/EmojiPicker/EmojiPicker.tsx on lines 57..68
              apps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPageHeader.tsx on lines 22..33

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status