Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx

Summary

Maintainability
F
5 days
Test Coverage

File EditRoomInfo.tsx has 528 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { IRoomWithRetentionPolicy } from '@rocket.chat/core-typings';
import { isRoomFederated } from '@rocket.chat/core-typings';
import type { SelectOption } from '@rocket.chat/fuselage';
import {
    FieldError,
Severity: Major
Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx - About 1 day to fix

    Function EditRoomInfo has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    const EditRoomInfo = ({ room, onClickClose, onClickBack }: EditRoomInfoProps) => {
    const t = useTranslation();
    const dispatchToastMessage = useToastMessageDispatch();
    const isFederated = useMemo(() => isRoomFederated(room), [room]);
    // eslint-disable-next-line no-nested-ternary
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                                                <Field>
                                                <FieldRow>
                                                    <FieldLabel htmlFor={retentionFilesOnlyField}>{t('RetentionPolicyRoom_FilesOnly')}</FieldLabel>
                                                    <Controller
                                                        control={control}
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 4 other locations - About 4 hrs to fix
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 416..425
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 565..574
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 438..447
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 486..497

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                                        <Field>
                                        <FieldRow>
                                            <FieldLabel htmlFor={retentionEnabledField}>{t('RetentionPolicyRoom_Enabled')}</FieldLabel>
                                            <Controller
                                                control={control}
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 4 other locations - About 4 hrs to fix
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 416..425
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 565..574
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 486..497
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 498..509

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                                                <Field>
                                                <FieldRow>
                                                    <FieldLabel htmlFor={retentionExcludePinnedField}>{t('RetentionPolicyRoom_ExcludePinned')}</FieldLabel>
                                                    <Controller
                                                        control={control}
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 4 other locations - About 4 hrs to fix
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 416..425
    apps/meteor/client/views/admin/emailInbox/EmailInboxForm.tsx on lines 565..574
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 438..447
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 498..509

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                    <FieldRow>
                                    <FieldLabel htmlFor={joinCodeRequiredField}>{t('Password_to_access')}</FieldLabel>
                                    <Controller
                                        control={control}
                                        name='joinCodeRequired'
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 3 hrs to fix
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 407..416

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                    <FieldRow>
                                    <FieldLabel htmlFor={hideSysMesField}>{t('Hide_System_Messages')}</FieldLabel>
                                    <Controller
                                        control={control}
                                        name='hideSysMes'
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 3 hrs to fix
    apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx on lines 384..393

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                    <FieldRow>
                                    <Controller
                                        name='roomAnnouncement'
                                        control={control}
                                        render={({ field }) => (
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 2 hrs to fix
    apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 300..313

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const {
        canChangeType,
        canSetReadOnly,
        canSetReactWhenReadOnly,
        canEditRoomRetentionPolicy,
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 2 hrs to fix
    apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx on lines 141..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            <Controller
                            control={control}
                            name='roomAvatar'
                            render={({ field: { onChange, value } }) => <RoomAvatarEditor room={room} roomAvatar={value} onChangeAvatar={onChange} />}
                        />
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 1 hr to fix
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 268..272

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                            render={({ field: { value, ...field } }) => (
                                            <ToggleSwitch
                                                id={reactWhenReadOnlyField}
                                                {...field}
                                                disabled={!canSetReactWhenReadOnly}
    Severity: Major
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 1 hr to fix
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 105..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const handleSave = useEffectEvent((data) =>
        Promise.all([isDirty && handleUpdateRoomData(data), changeArchiving && handleArchive()].filter(Boolean)),
    );
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 40 mins to fix
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 120..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        const teamNameRegex = useMemo(() => {
        if (allowSpecialNames) {
            return null;
        }
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 1 other location - About 35 mins to fix
    apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 56..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                                        <FieldHint id={`${reactWhenReadOnlyField}-hint`}>
                                        {reactWhenReadOnly ? t('Anyone_can_react_to_messages') : t('Only_authorized_users_can_react_to_messages')}
                                    </FieldHint>
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo/EditRoomInfo.tsx and 2 other locations - About 35 mins to fix
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 275..277
    apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 228..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status