Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function PruneMessagesWithData has 136 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const PruneMessagesWithData = (): ReactElement => {
    const t = useTranslation();
    const room = useRoom();
    const setModal = useSetModal();
    const { closeTab: close } = useRoomToolbox();
Severity: Major
Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx - About 5 hrs to fix

    Function PruneMessagesWithData has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

    const PruneMessagesWithData = (): ReactElement => {
    const t = useTranslation();
    const room = useRoom();
    const setModal = useSetModal();
    const { closeTab: close } = useRoomToolbox();
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function callOutText has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const callOutText = useMemo(() => {
        const exceptPinned = pinned ? ` ${t('except_pinned', {})}` : '';
        const ifFrom = users.length
            ? ` ${t('if_they_are_from', {
                    postProcess: 'sprintf',
    Severity: Minor
    Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx - About 1 hr to fix

      Function handlePrune has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const handlePrune = useMutableCallback((): void => {
        const handlePruneAction = async () => {
            const limit = DEFAULT_PRUNE_LIMIT;

            try {
      Severity: Minor
      Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx - About 1 hr to fix

        Function handlePruneAction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const handlePruneAction = async () => {
            const limit = DEFAULT_PRUNE_LIMIT;

            try {
                if (counter === limit) {
        Severity: Minor
        Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const fromDate = useMemo(() => {
        return new Date(`${newerDate || '0001-01-01'}T${newerTime || '00:00'}:00${getTimeZoneOffset()}`);
    }, [newerDate, newerTime]);
          Severity: Major
          Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx and 1 other location - About 1 hr to fix
          apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx on lines 67..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const toDate = useMemo(() => {
        return new Date(`${olderDate || '9999-12-31'}T${olderTime || '23:59'}:59${getTimeZoneOffset()}`);
    }, [olderDate, olderTime]);
          Severity: Major
          Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx and 1 other location - About 1 hr to fix
          apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx on lines 63..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (olderDate) {
            return (
                t('Prune_Warning_before', {
                    postProcess: 'sprintf',
                    sprintf: [filesOrMessages, name, moment(toDate).format('L LT')],
          Severity: Minor
          Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx and 1 other location - About 45 mins to fix
          apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx on lines 142..151

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (newerDate) {
            return (
                t('Prune_Warning_after', {
                    postProcess: 'sprintf',
                    sprintf: [filesOrMessages, name, moment(fromDate).format('L LT')],
          Severity: Minor
          Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx and 1 other location - About 45 mins to fix
          apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx on lines 153..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  <FormProvider {...methods}>
            <PruneMessages callOutText={callOutText} validateText={validateText} users={users} onClickClose={close} onClickPrune={handlePrune} />
        </FormProvider>
          Severity: Minor
          Found in apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessagesWithData.tsx and 2 other locations - About 30 mins to fix
          apps/meteor/client/views/admin/settings/Setting/inputs/RoomPickSettingInput.tsx on lines 41..49
          apps/meteor/client/views/audit/components/AuditLogEntry.tsx on lines 52..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status