RocketChat/Rocket.Chat

View on GitHub
apps/meteor/client/views/room/contextualBar/RoomFiles/hooks/useMessageDeletionIsAllowed.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function useMessageDeletionIsAllowed has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

export const useMessageDeletionIsAllowed = (rid: IRoom['_id'], file: IUpload, uid: IUser['_id'] | null) => {
    const canForceDelete = usePermission('force-delete-message', rid);
    const deletionIsEnabled = useSetting('Message_AllowDeleting');
    const userHasPermissionToDeleteAny = usePermission('delete-message', rid);
    const userHasPermissionToDeleteOwn = usePermission('delete-own-message');

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useMessageDeletionIsAllowed has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useMessageDeletionIsAllowed = (rid: IRoom['_id'], file: IUpload, uid: IUser['_id'] | null) => {
    const canForceDelete = usePermission('force-delete-message', rid);
    const deletionIsEnabled = useSetting('Message_AllowDeleting');
    const userHasPermissionToDeleteAny = usePermission('delete-message', rid);
    const userHasPermissionToDeleteOwn = usePermission('delete-own-message');

    Avoid too many return statements within this function.
    Open

            return false;

      There are no issues that match your filters.

      Category
      Status