Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/hooks/useRetentionPolicy.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this function.
Open

    return -Infinity;
Severity: Major
Found in apps/meteor/client/views/room/hooks/useRetentionPolicy.ts - About 30 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    const extractIgnoreThreads = (room: IRoom, { ignoreThreads }: RetentionPolicySettings): boolean => {
    if (hasRetentionPolicy(room) && isRetentionOverridden(room)) {
        return room.retention.ignoreThreads;
    }
    Severity: Major
    Found in apps/meteor/client/views/room/hooks/useRetentionPolicy.ts and 2 other locations - About 1 hr to fix
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 45..51
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 53..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    const extractExcludePinned = (room: IRoom, { doNotPrunePinned }: RetentionPolicySettings): boolean => {
    if (hasRetentionPolicy(room) && isRetentionOverridden(room)) {
        return room.retention.excludePinned;
    }
    Severity: Major
    Found in apps/meteor/client/views/room/hooks/useRetentionPolicy.ts and 2 other locations - About 1 hr to fix
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 45..51
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 61..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    const extractFilesOnly = (room: IRoom, { filesOnly }: RetentionPolicySettings): boolean => {
    if (hasRetentionPolicy(room) && isRetentionOverridden(room)) {
        return room.retention.filesOnly;
    }
    Severity: Major
    Found in apps/meteor/client/views/room/hooks/useRetentionPolicy.ts and 2 other locations - About 1 hr to fix
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 53..59
    apps/meteor/client/views/room/hooks/useRetentionPolicy.ts on lines 61..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const hasRetentionPolicy = (room: IRoom & { retention?: any }): room is IRoomWithRetentionPolicy =>
    'retention' in room && room.retention !== undefined;
    Severity: Major
    Found in apps/meteor/client/views/room/hooks/useRetentionPolicy.ts and 1 other location - About 1 hr to fix
    apps/meteor/app/channel-settings/server/methods/saveRoomSettings.ts on lines 62..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status