Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx

Summary

Maintainability
F
6 days
Test Coverage

Function ComposerPopupProvider has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

const ComposerPopupProvider = ({ children, room }: { children: ReactNode; room: IRoom }) => {
    const { _id: rid } = room;
    const userSpotlight = useMethod('spotlight');
    const suggestionsCount = useSetting<number>('Number_of_users_autocomplete_suggestions');
    const cannedResponseEnabled = useSetting<boolean>('Canned_Responses_Enable');
Severity: Minor
Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function value has 301 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const value: ComposerPopupContextValue = useMemo(() => {
        return [
            createMessageBoxPopupConfig({
                trigger: '@',
                title: t('People'),
Severity: Major
Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 day to fix

    File ComposerPopupProvider.tsx has 340 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import type { IRoom } from '@rocket.chat/core-typings';
import { isOmnichannelRoom } from '@rocket.chat/core-typings';
import { useLocalStorage } from '@rocket.chat/fuselage-hooks';
import { escapeRegExp } from '@rocket.chat/string-helpers';
import { useMethod, useSetting, useTranslation, useUserPreference } from '@rocket.chat/ui-contexts';
    Severity: Minor
    Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 4 hrs to fix

      Function getItemsFromLocal has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          getItemsFromLocal: async (filter: string) => {
                        const exactFinalTone = new RegExp('^tone[1-5]:*$');
                        const colorBlind = new RegExp('tone[1-5]:*$');
                        const seeColor = new RegExp('_t(?:o|$)(?:n|$)(?:e|$)(?:[1-5]|$)(?::|$)$');
      Severity: Minor
      Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 hr to fix

        Function getItemsFromLocal has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        getItemsFromLocal: async (filter: string) => {
                    const filterRegex = filter && new RegExp(escapeRegExp(filter), 'i');
                    const items: ComposerBoxPopupUserProps[] = [];

                    const users = usersFromRoomMessages
        Severity: Minor
        Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 hr to fix

          Function getItemsFromLocal has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          getItemsFromLocal: async (filter: string) => {
                    const exactFinalTone = new RegExp('^tone[1-5]:*$');
                    const colorBlind = new RegExp('tone[1-5]:*$');
                    const seeColor = new RegExp('_t(?:o|$)(?:n|$)(?:e|$)(?:[1-5]|$)(?::|$)$');
          Severity: Minor
          Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 hr to fix

            Function getItemsFromServer has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                            getItemsFromServer: async (filter: string) => {
                    const filterRegex = filter && new RegExp(escapeRegExp(filter), 'i');
                    const usernames = usersFromRoomMessages
                        .find(
                            {
            Severity: Minor
            Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      return Object.keys(collection)
                            .map((_id) => {
                                const data = collection[key];
                                return { _id, data };
                            })
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 5 hrs to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 257..267

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 147.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  return Object.keys(collection)
                        .map((_id) => {
                            const data = collection[key];
                            return { _id, data };
                        })
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 5 hrs to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 200..210

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 147.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  const users = usersFromRoomMessages
                        .find(
                            {
                                ts: { $exists: true },
                                ...(filter && {
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 2 hrs to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 89..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 85.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  const usernames = usersFromRoomMessages
                        .find(
                            {
                                ts: { $exists: true },
                                ...(filter && {
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 2 hrs to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 47..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 85.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!filterRegex || filterRegex.test('here')) {
                        items.push({
                            _id: 'here',
                            username: 'here',
                            system: true,
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 1 hr to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 65..73

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (!filterRegex || filterRegex.test('all')) {
                        items.push({
                            _id: 'all',
                            username: 'all',
                            system: true,
              Severity: Major
              Found in apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx and 1 other location - About 1 hr to fix
              apps/meteor/client/views/room/providers/ComposerPopupProvider.tsx on lines 75..83

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status