Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts

Summary

Maintainability
D
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should  throw an error when we try to convert app to guest', async () => {
        const user = {
            active: true,
            type: 'user',
            roles: ['guest'],
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 158..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should throw an error when we try to convert an user to guest', async () => {
        const user = {
            active: true,
            type: 'user',
            roles: ['guest'],
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 171..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        it('should not throw an error when we try to convert a bot to a user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 4 other locations - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 115..125
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 127..137
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 215..225
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 250..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        it('should not throw an error when we try to deactivate a user', async () => {
            const user = {
                active: false,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 4 other locations - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 127..137
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 215..225
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 239..249
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 250..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        it('should not throw an error when we try to change an active user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 4 other locations - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 115..125
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 215..225
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 239..249
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 250..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        it('should not throw an error when we try to convert an app to a user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 4 other locations - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 115..125
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 127..137
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 215..225
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 239..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        it('should not throw an error when we try to activate a user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 4 other locations - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 115..125
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 127..137
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 239..249
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 250..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it('should throw an error when we try to convert a bot to a user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 103..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it('should throw an error when we try to activate a user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 1 other location - About 2 hrs to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 139..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should not throw an error validating a regular user', async () => {
            const user = {
                active: true,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 3 other locations - About 1 hr to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 49..56
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 58..65
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 67..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should not throw error when user is a bot', async () => {
            const user = {
                active: true,
                type: 'bot',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 3 other locations - About 1 hr to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 49..56
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 58..65
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 205..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should not throw error when user is an app', async () => {
            const user = {
                active: true,
                type: 'app',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 3 other locations - About 1 hr to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 49..56
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 67..74
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 205..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should not throw error when user is not active', async () => {
            const user = {
                active: false,
                type: 'user',
            };
Severity: Major
Found in apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts and 3 other locations - About 1 hr to fix
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 58..65
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 67..74
apps/meteor/ee/app/authorization/server/validateUserRoles.spec.ts on lines 205..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status