Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/app/livechat-enterprise/server/api/triggers.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function post has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        async post() {
            const { _id: triggerId } = this.urlParams;
            const { token: visitorToken, extraData } = this.bodyParams;

            const trigger = await LivechatTrigger.findOneById(triggerId);
Severity: Minor
Found in apps/meteor/ee/app/livechat-enterprise/server/api/triggers.ts - About 1 hr to fix

    Function post has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            async post() {
            const { webhookUrl, timeout, fallbackMessage, extraData: clientParams } = this.bodyParams;

            const token = settings.get<string>('Livechat_secret_token');
    Severity: Minor
    Found in apps/meteor/ee/app/livechat-enterprise/server/api/triggers.ts - About 1 hr to fix

      Function post has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              async post() {
            const { _id: triggerId } = this.urlParams;
            const { token: visitorToken, extraData } = this.bodyParams;

            const trigger = await LivechatTrigger.findOneById(triggerId);
      Severity: Minor
      Found in apps/meteor/ee/app/livechat-enterprise/server/api/triggers.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status