Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts

Summary

Maintainability
C
1 day
Test Coverage

Function removeBHFromPreviouslyConnectedDepartmentAgentsIfRequired has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private async removeBHFromPreviouslyConnectedDepartmentAgentsIfRequired(departmentIds: string[]): Promise<void> {
        // we need to do 2 things here.
        // 1st is to check if any of the departments are associated with any BH. If they are, then we need to remove
        // that BH from all agents of that department.
        // 2nd is to check if any of the departments are not associated with BH, meaning default BH
Severity: Minor
Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts - About 1 hr to fix

    Function saveBusinessHour has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async saveBusinessHour(businessHour: ILivechatBusinessHour & IBusinessHoursExtraProperties): Promise<ILivechatBusinessHour> {
        const existingBusinessHour = (await this.BusinessHourRepository.findOne(
            { name: businessHour.name },
            { projection: { _id: 1 } },
        )) as ILivechatBusinessHour;
    Severity: Minor
    Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts - About 1 hr to fix

      Function removeBHFromPreviouslyConnectedDepartmentAgentsIfRequired has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private async removeBHFromPreviouslyConnectedDepartmentAgentsIfRequired(departmentIds: string[]): Promise<void> {
        // we need to do 2 things here.
        // 1st is to check if any of the departments are associated with any BH. If they are, then we need to remove
        // that BH from all agents of that department.
        // 2nd is to check if any of the departments are not associated with BH, meaning default BH
      Severity: Minor
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private async addBusinessHourToDepartmentsIfNeeded(businessHourId: string, departmentsToAdd: string[]): Promise<void> {
        if (!departmentsToAdd.length) {
            return;
        }
        await LivechatDepartment.addBusinessHourToDepartmentsByIds(departmentsToAdd, businessHourId);
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 1 other location - About 1 hr to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 103..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private async removeBusinessHourFromDepartmentsIfNeeded(businessHourId: string, departmentsToRemove: string[]): Promise<void> {
        if (!departmentsToRemove.length) {
            return;
        }
        await LivechatDepartment.removeBusinessHourFromDepartmentsByIdsAndBusinessHourId(departmentsToRemove, businessHourId);
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 1 other location - About 1 hr to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 158..163

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              const agentIds = (
            await LivechatDepartmentAgents.findByDepartmentIds(departmentIds, {
                projection: { agentId: 1 },
            }).toArray()
        ).map((dept) => dept.agentId);
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 4 other locations - About 55 mins to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 56..60
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 90..94
      apps/meteor/server/models/raw/Rooms.ts on lines 1226..1226
      apps/meteor/server/models/raw/Rooms.ts on lines 1257..1257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              const departmentIds = (
            await LivechatDepartment.findByBusinessHourId(businessHourId, {
                projection: { _id: 1 },
            }).toArray()
        ).map((dept) => dept._id);
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 4 other locations - About 55 mins to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 56..60
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 95..99
      apps/meteor/server/models/raw/Rooms.ts on lines 1226..1226
      apps/meteor/server/models/raw/Rooms.ts on lines 1257..1257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              const currentDepartments = (
            await LivechatDepartment.findByBusinessHourId(businessHourId, {
                projection: { _id: 1 },
            }).toArray()
        ).map((dept) => dept._id);
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 4 other locations - About 55 mins to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 90..94
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts on lines 95..99
      apps/meteor/server/models/raw/Rooms.ts on lines 1226..1226
      apps/meteor/server/models/raw/Rooms.ts on lines 1257..1257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const agentsConnectedToDefaultBH = await (
            await LivechatDepartmentAgents.findByDepartmentIds(departmentIds, {
                projection: { agentId: 1 },
            }).toArray()
        ).map((dept) => dept.agentId);
      Severity: Minor
      Found in apps/meteor/ee/app/livechat-enterprise/server/business-hour/Custom.ts and 1 other location - About 40 mins to fix
      apps/meteor/ee/app/livechat-enterprise/server/business-hour/Helper.ts on lines 21..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status