Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function getLivechatQueueInfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getLivechatQueueInfo = async (room?: IOmnichannelRoom) => {
    if (!room) {
        return null;
    }
Severity: Minor
Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 1 hr to fix

    Function getMaxNumberSimultaneousChat has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    export const getMaxNumberSimultaneousChat = async ({ agentId, departmentId }: { agentId?: string; departmentId?: string }) => {
    if (departmentId) {
        const department = await LivechatDepartmentRaw.findOneById(departmentId);
        const { maxNumberSimultaneousChat = 0 } = department || { maxNumberSimultaneousChat: 0 };
        if (maxNumberSimultaneousChat > 0) {
    Severity: Minor
    Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setPredictedVisitorAbandonmentTime has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export const setPredictedVisitorAbandonmentTime = async (
    room: Pick<IOmnichannelRoom, '_id' | 'responseBy' | 'departmentId'>,
    roomUpdater?: Updater<IOmnichannelRoom>,
) => {
    if (
    Severity: Minor
    Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return null;
    Severity: Major
    Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return null;
      Severity: Major
      Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return normalizeQueueInfo(inq);
        Severity: Major
        Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 30 mins to fix

          Function getLivechatQueueInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export const getLivechatQueueInfo = async (room?: IOmnichannelRoom) => {
    if (!room) {
        return null;
    }
          Severity: Minor
          Found in apps/meteor/ee/app/livechat-enterprise/server/lib/Helper.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status