Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function livechat:resumeOnHold has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async 'livechat:resumeOnHold'(roomId, options = { clientAction: false }) {
        methodDeprecationLogger.warn(
            'Method "livechat:resumeOnHold" is deprecated and will be removed in next major version. Please use "livechat/room.resumeOnHold" API instead.',
        );
Severity: Minor
Found in apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts - About 1 hr to fix

    Function livechat:resumeOnHold has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async 'livechat:resumeOnHold'(roomId, options = { clientAction: false }) {
        methodDeprecationLogger.warn(
            'Method "livechat:resumeOnHold" is deprecated and will be removed in next major version. Please use "livechat/room.resumeOnHold" API instead.',
        );
    Severity: Minor
    Found in apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 14 locations. Consider refactoring.
    Open

        const visitor = await LivechatVisitors.findOneEnabledById<Pick<ILivechatVisitor, 'name' | 'username'>>(visitorId, {
        projection: { name: 1, username: 1 },
    });
    Severity: Major
    Found in apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts and 13 other locations - About 1 hr to fix
    apps/meteor/app/2fa/server/functions/resetTOTP.ts on lines 12..14
    apps/meteor/app/livechat/server/lib/Departments.ts on lines 14..16
    apps/meteor/app/livechat/server/methods/searchAgent.ts on lines 33..35
    apps/meteor/ee/app/livechat-enterprise/server/hooks/resumeOnHold.ts on lines 15..17
    apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 78..81
    apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 155..160
    apps/meteor/server/modules/watchers/watchers.module.ts on lines 217..219
    apps/meteor/server/modules/watchers/watchers.module.ts on lines 227..229
    apps/meteor/server/services/team/service.ts on lines 327..327
    apps/meteor/server/services/team/service.ts on lines 400..400
    apps/meteor/server/services/team/service.ts on lines 525..527
    apps/meteor/server/services/team/service.ts on lines 768..770
    apps/meteor/app/api/server/v1/im.ts on lines 416..416

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status