Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx

Summary

Maintainability
F
1 wk
Test Coverage

File UnitEdit.tsx has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { ILivechatDepartment, ILivechatUnitMonitor, Serialized, IOmnichannelBusinessUnit } from '@rocket.chat/core-typings';
import type { SelectOption } from '@rocket.chat/fuselage';
import {
    FieldError,
    Field,
Severity: Minor
Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx - About 3 hrs to fix

    Function UnitEdit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const UnitEdit = ({ unitData, unitMonitors, unitDepartments }: UnitEditProps) => {
    const t = useTranslation();
    const router = useRouter();
    const saveUnit = useMethod('livechat:saveUnit');
    const dispatchToastMessage = useToastMessageDispatch();
    Severity: Minor
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            <Field>
                            <FieldLabel htmlFor={departmentsField} required>
                                {t('Departments')}
                            </FieldLabel>
                            <FieldRow>
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 2 days to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 254..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 364.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            <Field>
                            <FieldLabel htmlFor={monitorsField} required>
                                {t('Monitors')}
                            </FieldLabel>
                            <FieldRow>
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 2 days to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 214..253

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 364.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <ContextualbarFooter>
                <ButtonGroup stretch>
                    <Button onClick={() => router.navigate('/omnichannel/units')}>{t('Cancel')}</Button>
                    <Button form={formId} disabled={!isDirty} type='submit' primary>
                        {t('Save')}
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 1 day to fix
    apps/meteor/ee/client/omnichannel/tags/TagEdit.tsx on lines 122..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const departmentsOptions = useMemo(() => {
        const pending = departments.filter(({ value }) => !departmentsItems.find((dep) => dep._id === value));
        const mappedDepartmentsItems = departmentsItems?.map(({ _id, name }) => ({
            value: _id,
            label: name,
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 4 hrs to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 120..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const monitorsOptions = useMemo(() => {
        const pending = monitors.filter(({ value }) => !monitorsItems.find((mon) => mon._id === value));
        const mappedMonitorsItems = monitorsItems?.map(({ _id, name }) => ({
            value: _id,
            label: name,
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 4 hrs to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 111..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <ContextualbarHeader>
                <ContextualbarTitle>{_id ? t('Edit_Unit') : t('New_Unit')}</ContextualbarTitle>
                <ContextualbarClose onClick={() => router.navigate('/omnichannel/units')}></ContextualbarClose>
            </ContextualbarHeader>
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 1 hr to fix
    apps/meteor/ee/client/omnichannel/tags/TagEdit.tsx on lines 76..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const currUnitMonitors = useMemo(
        () =>
            unitMonitors?.map(({ _id, username }) => ({
                value: _id,
                label: username,
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 1 hr to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 76..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const currUnitDepartments = useMemo(
        () =>
            unitDepartments?.map(({ _id, name }) => ({
                value: _id,
                label: name,
    Severity: Major
    Found in apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx and 1 other location - About 1 hr to fix
    apps/meteor/ee/client/omnichannel/units/UnitEdit.tsx on lines 85..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status