Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/server/lib/oauth/Manager.ts

Summary

Maintainability
C
1 day
Test Coverage

Function mapSSOGroupsToChannels has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    static async mapSSOGroupsToChannels(
        user: IUser,
        identity: Record<string, any>,
        groupClaimName: string,
        channelsMap: Record<string, any> | undefined,
Severity: Minor
Found in apps/meteor/ee/server/lib/oauth/Manager.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mapSSOGroupsToChannels has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static async mapSSOGroupsToChannels(
        user: IUser,
        identity: Record<string, any>,
        groupClaimName: string,
        channelsMap: Record<string, any> | undefined,
Severity: Minor
Found in apps/meteor/ee/server/lib/oauth/Manager.ts - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if (room && Array.isArray(groupsFromSSO) && groupsFromSSO.includes(ssoGroup)) {
                            await addUserToRoom(room._id, user);
                        }
    Severity: Major
    Found in apps/meteor/ee/server/lib/oauth/Manager.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (!room) {
                            const createdRoom = await createRoom('c', channel, userChannelAdmin, [], false, false);
                            if (!createdRoom?.rid) {
                                logger.error(`could not create channel ${channel}`);
                                return;
      Severity: Major
      Found in apps/meteor/ee/server/lib/oauth/Manager.ts - About 45 mins to fix

        Function mapRolesFromSSO has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            static async mapRolesFromSSO(identity: Record<string, any>, roleClaimName: string): Promise<string[]> {
        if (!identity || !roleClaimName || !identity[roleClaimName] || !Array.isArray(identity[roleClaimName])) {
            return [];
        }
        Severity: Minor
        Found in apps/meteor/ee/server/lib/oauth/Manager.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status