Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function createExternalDirectMessageRoomAndInviteUsers has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private async createExternalDirectMessageRoomAndInviteUsers(
        dmRoomOnCreationInput: FederationOnDirectMessageRoomCreationDto,
    ): Promise<void> {
        const { internalRoomId, internalInviterId, invitees } = dmRoomOnCreationInput;
Severity: Minor
Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts - About 1 hr to fix

    Function createUserForDirectMessageRoom has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private async createUserForDirectMessageRoom(roomInviteUserInput: FederationRoomInviteUserDto): Promise<void> {
        const { normalizedInviteeId, inviteeUsernameOnly, rawInviteeId } = roomInviteUserInput;

        const isInviteeFromTheSameHomeServer = FederatedUserEE.isOriginalFromTheProxyServer(
            this.bridge.extractHomeserverOrigin(rawInviteeId),
    Severity: Minor
    Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          constructor(
        protected internalRoomAdapter: RocketChatRoomAdapterEE,
        protected internalUserAdapter: RocketChatUserAdapterEE,
        protected internalFileAdapter: RocketChatFileAdapter,
        protected internalSettingsAdapter: RocketChatSettingsAdapter,
      Severity: Major
      Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts and 2 other locations - About 1 hr to fix
      apps/meteor/server/services/federation/application/room/sender/RoomInternalValidator.ts on lines 14..22
      apps/meteor/server/services/federation/application/user/sender/UserServiceSender.ts on lines 9..17

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              const atLeastOneExternalUser = invitees.some(
            (invitee) =>
                !FederatedUserEE.isOriginalFromTheProxyServer(
                    this.bridge.extractHomeserverOrigin(invitee.rawInviteeId),
                    this.internalHomeServerDomain,
      Severity: Major
      Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts and 2 other locations - About 45 mins to fix
      apps/meteor/ee/server/local-services/federation/application/AbstractFederationApplicationServiceEE.ts on lines 20..26
      apps/meteor/ee/server/local-services/federation/application/room/sender/RoomServiceSender.ts on lines 90..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const inviteesFromTheSameHomeServer = invitees.filter((invitee) =>
            FederatedUserEE.isOriginalFromTheProxyServer(
                this.bridge.extractHomeserverOrigin(invitee.rawInviteeId),
                this.internalHomeServerDomain,
            ),
      Severity: Minor
      Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts and 1 other location - About 40 mins to fix
      apps/meteor/ee/server/local-services/federation/application/room/sender/RoomServiceSender.ts on lines 86..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      this.createUserForDirectMessageRoom({
                    internalInviterId,
                    internalRoomId,
                    inviteeUsernameOnly: member.inviteeUsernameOnly,
                    normalizedInviteeId: member.normalizedInviteeId,
      Severity: Minor
      Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts and 1 other location - About 35 mins to fix
      apps/meteor/ee/server/local-services/federation/application/room/sender/RoomServiceSender.ts on lines 99..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              await this.bridge.createUser(
            inviteeUsernameOnly,
            federatedInviteeUser.getName() || federatedInviteeUser.getUsername() || inviteeUsernameOnly,
            this.internalHomeServerDomain,
        );
      Severity: Minor
      Found in apps/meteor/ee/server/local-services/federation/application/room/sender/DirectMessageRoomServiceSender.ts and 1 other location - About 30 mins to fix
      apps/meteor/ee/server/local-services/federation/application/room/sender/RoomServiceSender.ts on lines 273..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status