Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/ee/server/models/raw/LivechatDepartment.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function findAgentsByBusinessHourId has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    findAgentsByBusinessHourId(businessHourId: string): AggregationCursor<{ agentIds: string[] }> {
        return this.col.aggregate<{ agentIds: string[] }>([
            [
                {
                    $match: {
Severity: Minor
Found in apps/meteor/ee/server/models/raw/LivechatDepartment.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            unfilteredUpdate(
            query: Filter<ILivechatDepartment>,
            update: UpdateFilter<ILivechatDepartment>,
            options: FindOptions<ILivechatDepartment>,
        ): Promise<UpdateResult>;
    Severity: Major
    Found in apps/meteor/ee/server/models/raw/LivechatDepartment.ts and 1 other location - About 1 hr to fix
    packages/model-typings/src/models/ILivechatUnitModel.ts on lines 21..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            unfilteredFindOne(query: Filter<ILivechatDepartment>, options: FindOptions<ILivechatDepartment>): Promise<ILivechatDepartment | null>;
    Severity: Minor
    Found in apps/meteor/ee/server/models/raw/LivechatDepartment.ts and 1 other location - About 30 mins to fix
    packages/model-typings/src/models/ILivechatUnitModel.ts on lines 17..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status