Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/packages/flow-router/client/router.js

Summary

Maintainability
D
2 days
Test Coverage

File router.js has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Router = function () {
    var self = this;
    this.globals = [];
    this.subscriptions = Function.prototype;
Severity: Minor
Found in apps/meteor/packages/flow-router/client/router.js - About 4 hrs to fix

    Function _buildTracker has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Router.prototype._buildTracker = function () {
    var self = this;

    // main autorun function
    var tracker = Tracker.autorun(function () {
    Severity: Minor
    Found in apps/meteor/packages/flow-router/client/router.js - About 1 hr to fix

      Function subsReady has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Router.prototype.subsReady = function () {
    var callback = null;
    var args = _.toArray(arguments);

    if (typeof _.last(args) === 'function') {
      Severity: Minor
      Found in apps/meteor/packages/flow-router/client/router.js - About 1 hr to fix

        Function route has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Router.prototype.route = function (pathDef, options, group) {
    if (!/^\/.*/.test(pathDef)) {
        var message = "route's path must start with '/'";
        throw new Error(message);
    }
        Severity: Minor
        Found in apps/meteor/packages/flow-router/client/router.js - About 1 hr to fix

          Function tracker has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var tracker = Tracker.autorun(function () {
        if (!self._current || !self._current.route) {
            return;
        }
          Severity: Minor
          Found in apps/meteor/packages/flow-router/client/router.js - About 1 hr to fix

            Function path has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            Router.prototype.path = function (pathDef, fields, queryParams) {
    if (this._routesMap[pathDef]) {
        pathDef = this._routesMap[pathDef].pathDef;
    }
            Severity: Minor
            Found in apps/meteor/packages/flow-router/client/router.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function subsReady has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            Router.prototype.subsReady = function () {
    var callback = null;
    var args = _.toArray(arguments);

    if (typeof _.last(args) === 'function') {
            Severity: Minor
            Found in apps/meteor/packages/flow-router/client/router.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _invalidateTracker has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            Router.prototype._invalidateTracker = function () {
    var self = this;
    this.safeToRun++;
    this._tracker.invalidate();
    // After the invalidation we need to flush to make changes imediately
            Severity: Minor
            Found in apps/meteor/packages/flow-router/client/router.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Router.prototype._triggerRouteRegister = function (currentRoute) {
    // We should only need to send a safe set of fields on the route
    // object.
    // This is not to hide what's inside the route object, but to show
    // these are the public APIs
            Severity: Major
            Found in apps/meteor/packages/flow-router/client/router.js and 1 other location - About 3 hrs to fix
            apps/meteor/packages/flow-router/server/router.js on lines 69..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    enter: function (triggers, filter) {
            triggers = Triggers.applyFilters(triggers, filter);
            if (triggers.length) {
                self._triggersEnter = self._triggersEnter.concat(triggers);
            }
            Severity: Major
            Found in apps/meteor/packages/flow-router/client/router.js and 1 other location - About 1 hr to fix
            apps/meteor/packages/flow-router/client/router.js on lines 539..544

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    exit: function (triggers, filter) {
            triggers = Triggers.applyFilters(triggers, filter);
            if (triggers.length) {
                self._triggersExit = self._triggersExit.concat(triggers);
            }
            Severity: Major
            Found in apps/meteor/packages/flow-router/client/router.js and 1 other location - About 1 hr to fix
            apps/meteor/packages/flow-router/client/router.js on lines 532..537

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status