Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts

Summary

Maintainability
C
1 day
Test Coverage

Function onEmailReceived has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function onEmailReceived(email: ParsedMail, inbox: string, department = ''): Promise<void> {
    logger.info(`New email conversation received on inbox ${inbox}. Will be assigned to department ${department}`);
    if (!email.from?.value?.[0]?.address) {
        return;
    }
Severity: Major
Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts - About 5 hrs to fix

    Function uploadAttachment has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function uploadAttachment(attachmentParam: Attachment, rid: string, visitorToken: string): Promise<Partial<FileAttachment>> {
    const details = {
        name: attachmentParam.filename,
        size: attachmentParam.size,
        type: attachmentParam.contentType,
    Severity: Minor
    Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts - About 1 hr to fix

      Function onEmailReceived has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function onEmailReceived(email: ParsedMail, inbox: string, department = ''): Promise<void> {
    logger.info(`New email conversation received on inbox ${inbox}. Will be assigned to department ${department}`);
    if (!email.from?.value?.[0]?.address) {
        return;
    }
      Severity: Minor
      Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getGuestByEmail has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      async function getGuestByEmail(email: string, name: string, department = ''): Promise<ILivechatVisitor | null> {
    const guest = await LivechatVisitors.findOneGuestByEmailAddress(email);

    if (guest) {
        if (guest.department !== department) {
      Severity: Minor
      Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function uploadAttachment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function uploadAttachment(attachmentParam: Attachment, rid: string, visitorToken: string): Promise<Partial<FileAttachment>> {
    const details = {
        name: attachmentParam.filename,
        size: attachmentParam.size,
        type: attachmentParam.contentType,
      Severity: Minor
      Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (file.type && /^audio\/.+/.test(file.type)) {
        attachment.audio_url = url;
        attachment.audio_type = file.type;
        attachment.audio_size = file.size;
    }
      Severity: Major
      Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts on lines 90..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (file.type && /^video\/.+/.test(file.type)) {
        attachment.video_url = url;
        attachment.video_type = file.type;
        attachment.video_size = file.size;
    }
      Severity: Major
      Found in apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/features/EmailInbox/EmailInbox_Incoming.ts on lines 84..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status