Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/lib/ldap/Connection.ts

Summary

Maintainability
F
4 days
Test Coverage

File Connection.ts has 683 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type {
    ILDAPConnectionOptions,
    LDAPEncryptionType,
    LDAPSearchScope,
    ILDAPEntry,
Severity: Major
Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 day to fix

    LDAPConnection has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class LDAPConnection {
    public ldapjs: any;

    public connected: boolean;
    Severity: Minor
    Found in apps/meteor/server/lib/ldap/Connection.ts - About 3 hrs to fix

      Function doPagedSearch has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private async doPagedSearch<T = ldapjs.SearchEntry>(
        baseDN: string,
        searchOptions: ldapjs.SearchOptions,
        pageSize: number,
        callback: ILDAPPageCallback,
      Severity: Major
      Found in apps/meteor/server/lib/ldap/Connection.ts - About 3 hrs to fix

        Function initializeConnection has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private initializeConnection(callback: ILDAPCallback): void {
        connLogger.info('Init Setup');
        this._receivedResponse = false;
        this._connectionTimedOut = false;
        this._connectionCallback = callback;
        Severity: Minor
        Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

          Function searchAllUsers has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public async searchAllUsers<T = ldapjs.SearchEntry>({
        dataCallback,
        endCallback,
        entryCallback,
    }: ILDAPSearchAllCallbacks<T>): Promise<void> {
          Severity: Minor
          Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

            Function constructor has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                constructor() {
        this.ldapjs = ldapjs;

        this.connected = false;
        this._receivedResponse = false;
            Severity: Minor
            Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

              Function doCustomSearch has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public async doCustomSearch<T>(baseDN: string, searchOptions: ldapjs.SearchOptions, entryCallback: ILDAPEntryCallback<T>): Promise<T[]> {
        await this.runBeforeSearch(searchOptions);

        if (!searchOptions.scope) {
            searchOptions.scope = this.options.userSearchScope || 'sub';
              Severity: Minor
              Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                Function getClientOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private getClientOptions(): {
        clientOptions: ldapjs.ClientOptions;
        tlsOptions: Record<string, any>;
    } {
        const clientOptions: ldapjs.ClientOptions = {
                Severity: Minor
                Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                  Function searchMembersOfGroupFilter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public async searchMembersOfGroupFilter(): Promise<string[]> {
        if (!this.options.groupFilterEnabled) {
            return [];
        }
                  Severity: Minor
                  Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                    Function searchById has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public async searchById(id: string, attribute?: string): Promise<ILDAPEntry[]> {
        const searchOptions: ldapjs.SearchOptions = {
            scope: this.options.userSearchScope || 'sub',
            attributes: this.options.attributesToQuery,
        };
                    Severity: Minor
                    Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                      Function isUserAcceptedByGroupFilter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public async isUserAcceptedByGroupFilter(username: string, userdn: string): Promise<boolean> {
        if (!this.options.groupFilterEnabled) {
            return true;
        }
                      Severity: Minor
                      Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                        Function doAsyncSearch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private async doAsyncSearch<T = ldapjs.SearchEntry>(
        baseDN: string,
        searchOptions: ldapjs.SearchOptions,
        callback: ILDAPCallback,
        entryCallback?: ILDAPEntryCallback<T>,
                        Severity: Minor
                        Found in apps/meteor/server/lib/ldap/Connection.ts - About 1 hr to fix

                          Function searchById has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public async searchById(id: string, attribute?: string): Promise<ILDAPEntry[]> {
        const searchOptions: ldapjs.SearchOptions = {
            scope: this.options.userSearchScope || 'sub',
            attributes: this.options.attributesToQuery,
        };
                          Severity: Minor
                          Found in apps/meteor/server/lib/ldap/Connection.ts - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid too many return statements within this function.
                          Open

                                  return ensureArray<string>(members);
                          Severity: Major
                          Found in apps/meteor/server/lib/ldap/Connection.ts - About 30 mins to fix

                            Function searchMembersOfGroupFilter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public async searchMembersOfGroupFilter(): Promise<string[]> {
        if (!this.options.groupFilterEnabled) {
            return [];
        }
                            Severity: Minor
                            Found in apps/meteor/server/lib/ldap/Connection.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                constructor() {
        this.ldapjs = ldapjs;

        this.connected = false;
        this._receivedResponse = false;
                            Severity: Minor
                            Found in apps/meteor/server/lib/ldap/Connection.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function handleConnectionResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private handleConnectionResponse(error: any, response?: any): void {
        if (!this._receivedResponse) {
            this._receivedResponse = true;
            this._connectionCallback(error, response);
            return;
                            Severity: Minor
                            Found in apps/meteor/server/lib/ldap/Connection.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if (this.options.groupFilterGroupIdAttribute) {
            filter.push(`(${this.options.groupFilterGroupIdAttribute}=${this.options.groupFilterGroupName})`);
        }
                            Severity: Major
                            Found in apps/meteor/server/lib/ldap/Connection.ts and 2 other locations - About 1 hr to fix
                            apps/meteor/server/lib/ldap/Connection.ts on lines 449..451
                            apps/meteor/server/lib/ldap/Connection.ts on lines 453..455

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 55.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if (this.options.groupFilterGroupIdAttribute) {
            filter.push(`(${this.options.groupFilterGroupIdAttribute}=${this.options.groupFilterGroupName})`);
        }
                            Severity: Major
                            Found in apps/meteor/server/lib/ldap/Connection.ts and 2 other locations - About 1 hr to fix
                            apps/meteor/server/lib/ldap/Connection.ts on lines 415..417
                            apps/meteor/server/lib/ldap/Connection.ts on lines 449..451

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 55.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if (this.options.groupFilterGroupMemberAttribute) {
            filter.push(`(${this.options.groupFilterGroupMemberAttribute}=${this.options.groupFilterGroupMemberFormat})`);
        }
                            Severity: Major
                            Found in apps/meteor/server/lib/ldap/Connection.ts and 2 other locations - About 1 hr to fix
                            apps/meteor/server/lib/ldap/Connection.ts on lines 415..417
                            apps/meteor/server/lib/ldap/Connection.ts on lines 453..455

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 55.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            if (entries.length) {
                    this.processSearchPage<T>(
                        {
                            entries,
                            title: 'Final Page',
                            Severity: Minor
                            Found in apps/meteor/server/lib/ldap/Connection.ts and 1 other location - About 35 mins to fix
                            apps/meteor/server/lib/ldap/Connection.ts on lines 599..609

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                if (entries.length >= internalPageSize) {
                        this.processSearchPage<T>(
                            {
                                entries,
                                title: 'Internal Page',
                            Severity: Minor
                            Found in apps/meteor/server/lib/ldap/Connection.ts and 1 other location - About 35 mins to fix
                            apps/meteor/server/lib/ldap/Connection.ts on lines 643..653

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status