Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/lib/migrations.ts

Summary

Maintainability
D
1 day
Test Coverage

Function migrateDatabase has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function migrateDatabase(targetVersion: 'latest' | number, subcommands?: string[]): Promise<boolean> {
    const control = await getControl();
    const currentVersion = control.version;

    const orderedMigrations = getOrderedMigrations();
Severity: Major
Found in apps/meteor/server/lib/migrations.ts - About 4 hrs to fix

    Function migrateDatabase has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function migrateDatabase(targetVersion: 'latest' | number, subcommands?: string[]): Promise<boolean> {
    const control = await getControl();
    const currentVersion = control.version;

    const orderedMigrations = getOrderedMigrations();
    Severity: Minor
    Found in apps/meteor/server/lib/migrations.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File migrations.ts has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import type { IControl } from '@rocket.chat/core-typings';
import { Logger } from '@rocket.chat/logger';
import { Migrations } from '@rocket.chat/models';

import { Info } from '../../app/utils/rocketchat.info';
    Severity: Minor
    Found in apps/meteor/server/lib/migrations.ts - About 2 hrs to fix

      Function lock has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function lock(): Promise<boolean> {
    const date = new Date();
    const dateMinusInterval = new Date();
    dateMinusInterval.setMinutes(dateMinusInterval.getMinutes() - 5);
      Severity: Minor
      Found in apps/meteor/server/lib/migrations.ts - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                return true;
        Severity: Major
        Found in apps/meteor/server/lib/migrations.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return true;
          Severity: Major
          Found in apps/meteor/server/lib/migrations.ts - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                try {
        const migrations = [];
        if (currentVersion < version) {
            for (let i = startIdx; i < endIdx; i++) {
                migrations.push(async () => {
            Severity: Minor
            Found in apps/meteor/server/lib/migrations.ts and 1 other location - About 30 mins to fix
            apps/meteor/server/lib/migrations.ts on lines 222..228

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
            await migrate('up', migration);
        } catch (e) {
            showError(version, control, e);
            log.error({ err: e });
            Severity: Minor
            Found in apps/meteor/server/lib/migrations.ts and 1 other location - About 30 mins to fix
            apps/meteor/server/lib/migrations.ts on lines 252..282

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status