Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/methods/getUsersOfRoom.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function getUsersOfRoom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async getUsersOfRoom(rid, showAll, { limit, skip } = {}, filter) {
        if (!rid) {
            throw new Meteor.Error('error-invalid-room', 'Invalid room', { method: 'getUsersOfRoom' });
        }
Severity: Minor
Found in apps/meteor/server/methods/getUsersOfRoom.ts - About 1 hr to fix

    Function getUsersOfRoom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        async getUsersOfRoom(rid, showAll, { limit, skip } = {}, filter) {
        if (!rid) {
            throw new Meteor.Error('error-invalid-room', 'Invalid room', { method: 'getUsersOfRoom' });
        }
    Severity: Minor
    Found in apps/meteor/server/methods/getUsersOfRoom.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status