Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/methods/loadHistory.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function loadHistory has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    async loadHistory(rid, end, limit = 20, ls, showThreadMessages = true) {
        check(rid, String);

        if (!Meteor.userId() && settings.get('Accounts_AllowAnonymousRead') === false) {
            throw new Meteor.Error('error-invalid-user', 'Invalid user', {
Severity: Minor
Found in apps/meteor/server/methods/loadHistory.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadHistory has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    async loadHistory(rid, end, limit = 20, ls, showThreadMessages = true) {
Severity: Minor
Found in apps/meteor/server/methods/loadHistory.ts - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

            return loadMessageHistory({ userId: fromId, rid, end, limit, ls, showThreadMessages });
    Severity: Major
    Found in apps/meteor/server/methods/loadHistory.ts - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status