Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/modules/watchers/watchers.module.ts

Summary

Maintainability
F
4 days
Test Coverage

Function initWatchers has 303 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function initWatchers(watcher: DatabaseWatcher, broadcast: BroadcastCallback): void {
    // watch for changes on the database and broadcast them to the other instances
    if (!dbWatchersDisabled) {
        watcher.on<IMessage>(Messages.getCollectionName(), async ({ clientAction, id, data }) => {
            switch (clientAction) {
Severity: Major
Found in apps/meteor/server/modules/watchers/watchers.module.ts - About 1 day to fix

    File watchers.module.ts has 364 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import type { EventSignatures } from '@rocket.chat/core-services';
import { dbWatchersDisabled } from '@rocket.chat/core-services';
import type {
    ISubscription,
    IUser,
    Severity: Minor
    Found in apps/meteor/server/modules/watchers/watchers.module.ts - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          watcher.on<IIntegration>(Integrations.getCollectionName(), async ({ clientAction, id, data: eventData }) => {
        if (clientAction === 'removed') {
            void broadcast('watch.integrations', { clientAction, id, data: { _id: id } });
            return;
        }
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 1 other location - About 5 hrs to fix
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 397..409

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          watcher.on<IEmailInbox>(EmailInbox.getCollectionName(), async ({ clientAction, id, data: eventData }) => {
        if (clientAction === 'removed') {
            void broadcast('watch.emailInbox', { clientAction, id, data: { _id: id } });
            return;
        }
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 1 other location - About 5 hrs to fix
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 383..395

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                              Pick<
                            ISubscription,
                            | 't'
                            | 'ts'
                            | 'ls'
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 1 other location - About 5 hrs to fix
      packages/core-services/src/events/Events.ts on lines 174..222

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 147.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

              const data = await LivechatDepartmentAgents.findOneById<Pick<ILivechatDepartmentAgents, 'agentId' | 'departmentId'>>(id, {
            projection: { agentId: 1, departmentId: 1 },
        });
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 13 other locations - About 1 hr to fix
      apps/meteor/app/2fa/server/functions/resetTOTP.ts on lines 11..13
      apps/meteor/app/livechat/server/lib/Departments.ts on lines 13..15
      apps/meteor/app/livechat/server/methods/searchAgent.ts on lines 33..35
      apps/meteor/ee/app/livechat-enterprise/server/hooks/resumeOnHold.ts on lines 15..17
      apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 77..80
      apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 151..156
      apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts on lines 22..24
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 217..219
      apps/meteor/server/services/team/service.ts on lines 325..325
      apps/meteor/server/services/team/service.ts on lines 398..398
      apps/meteor/server/services/team/service.ts on lines 513..515
      apps/meteor/server/services/team/service.ts on lines 752..754
      apps/meteor/app/api/server/v1/im.ts on lines 416..416

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 14 locations. Consider refactoring.
      Open

                  const data = await LivechatDepartmentAgents.trashFindOneById<Pick<ILivechatDepartmentAgents, 'agentId' | 'departmentId'>>(id, {
                projection: { agentId: 1, departmentId: 1 },
            });
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 13 other locations - About 1 hr to fix
      apps/meteor/app/2fa/server/functions/resetTOTP.ts on lines 11..13
      apps/meteor/app/livechat/server/lib/Departments.ts on lines 13..15
      apps/meteor/app/livechat/server/methods/searchAgent.ts on lines 33..35
      apps/meteor/ee/app/livechat-enterprise/server/hooks/resumeOnHold.ts on lines 15..17
      apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 77..80
      apps/meteor/ee/app/livechat-enterprise/server/lib/VisitorInactivityMonitor.ts on lines 151..156
      apps/meteor/ee/app/livechat-enterprise/server/methods/resumeOnHold.ts on lines 22..24
      apps/meteor/server/modules/watchers/watchers.module.ts on lines 227..229
      apps/meteor/server/services/team/service.ts on lines 325..325
      apps/meteor/server/services/team/service.ts on lines 398..398
      apps/meteor/server/services/team/service.ts on lines 513..515
      apps/meteor/server/services/team/service.ts on lines 752..754
      apps/meteor/app/api/server/v1/im.ts on lines 416..416

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

              const data = await LoginServiceConfiguration.findOne<Omit<ILoginServiceConfiguration, 'secret'>>(id, { projection: { secret: 0 } });
      Severity: Major
      Found in apps/meteor/server/modules/watchers/watchers.module.ts and 16 other locations - About 30 mins to fix
      apps/meteor/app/api/server/lib/messages.ts on lines 25..25
      apps/meteor/app/api/server/lib/messages.ts on lines 64..64
      apps/meteor/app/authorization/server/methods/addUserToRole.ts on lines 35..35
      apps/meteor/app/authorization/server/methods/removeUserFromRole.ts on lines 35..35
      apps/meteor/app/livechat/server/lib/QueueManager.ts on lines 136..136
      apps/meteor/app/statistics/server/lib/SAUMonitor.ts on lines 27..27
      apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts on lines 88..88
      apps/meteor/ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.ts on lines 19..21
      apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadForwardDepartmentRestrictions.ts on lines 13..15
      apps/meteor/ee/server/configuration/videoConference.ts on lines 23..23
      apps/meteor/ee/server/configuration/videoConference.ts on lines 35..35
      apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts on lines 65..65
      apps/meteor/server/modules/watchers/lib/messages.ts on lines 10..10
      apps/meteor/server/services/banner/service.ts on lines 51..53
      apps/meteor/server/services/team/service.ts on lines 425..425
      apps/meteor/server/services/team/service.ts on lines 701..703

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status