Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/banner/service.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function dismiss has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async dismiss(userId: string, bannerId: string): Promise<boolean> {
        if (!userId || !bannerId) {
            throw new Error('Invalid params');
        }
Severity: Minor
Found in apps/meteor/server/services/banner/service.ts - About 1 hr to fix

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

            const user = await Users.findOneById<Pick<IUser, 'username' | '_id'>>(userId, {
            projection: { username: 1 },
        });
    Severity: Major
    Found in apps/meteor/server/services/banner/service.ts and 9 other locations - About 45 mins to fix
    apps/meteor/app/authorization/server/functions/getUsersInRole.ts on lines 35..35
    apps/meteor/app/e2e/server/methods/setRoomKeyID.ts on lines 35..35
    apps/meteor/app/livechat/server/statistics/LivechatAgentActivityMonitor.ts on lines 111..111
    apps/meteor/app/livechat/server/statistics/LivechatAgentActivityMonitor.ts on lines 128..128
    apps/meteor/ee/app/livechat-enterprise/server/hooks/afterForwardChatToDepartment.ts on lines 12..14
    apps/meteor/ee/app/livechat-enterprise/server/hooks/afterForwardChatToDepartment.ts on lines 20..22
    apps/meteor/ee/app/livechat-enterprise/server/hooks/manageDepartmentUnit.ts on lines 29..31
    apps/meteor/server/services/team/service.ts on lines 55..57
    apps/meteor/server/services/team/service.ts on lines 144..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 19 locations. Consider refactoring.
    Open

            const user = await Users.findOneById<Pick<IUser, 'roles'>>(userId, {
            projection: { roles: 1 },
        });
    Severity: Major
    Found in apps/meteor/server/services/banner/service.ts and 18 other locations - About 30 mins to fix
    apps/meteor/app/api/server/lib/messages.ts on lines 25..25
    apps/meteor/app/api/server/lib/messages.ts on lines 64..64
    apps/meteor/app/authorization/server/methods/addUserToRole.ts on lines 35..35
    apps/meteor/app/authorization/server/methods/removeUserFromRole.ts on lines 35..35
    apps/meteor/app/lib/server/lib/notifyListener.ts on lines 167..169
    apps/meteor/app/lib/server/lib/notifyListener.ts on lines 417..417
    apps/meteor/app/livechat/server/lib/Contacts.ts on lines 231..231
    apps/meteor/app/livechat/server/lib/Contacts.ts on lines 295..295
    apps/meteor/app/statistics/server/lib/SAUMonitor.ts on lines 27..27
    apps/meteor/ee/app/livechat-enterprise/server/api/lib/priorities.ts on lines 88..88
    apps/meteor/ee/app/livechat-enterprise/server/hooks/beforeForwardRoomToDepartment.ts on lines 19..21
    apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadForwardDepartmentRestrictions.ts on lines 13..15
    apps/meteor/ee/server/configuration/videoConference.ts on lines 23..23
    apps/meteor/ee/server/configuration/videoConference.ts on lines 35..35
    apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts on lines 65..65
    apps/meteor/server/modules/watchers/watchers.module.ts on lines 343..343
    apps/meteor/server/services/team/service.ts on lines 428..428
    apps/meteor/server/services/team/service.ts on lines 714..716

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status