Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function sendExternalMessageReaction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public async sendExternalMessageReaction(internalMessage: IMessage, internalUser: IUser, reaction: string): Promise<void> {
        if (!internalMessage || !internalUser || !internalUser._id || !internalMessage.rid) {
            return;
        }
        const federatedSender = await this.internalUserAdapter.getFederatedUserByInternalId(internalUser._id);
Severity: Minor
Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 1 hr to fix

    Function sendExternalMessageUnReaction has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public async sendExternalMessageUnReaction(internalMessage: IMessage, internalUser: IUser, reaction: string): Promise<void> {
        if (!internalMessage || !internalUser || !internalUser._id || !internalMessage.rid) {
            return;
        }
        const federatedSender = await this.internalUserAdapter.getFederatedUserByInternalId(internalUser._id);
    Severity: Minor
    Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 1 hr to fix

      Function sendExternalMessageUnReaction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public async sendExternalMessageUnReaction(internalMessage: IMessage, internalUser: IUser, reaction: string): Promise<void> {
        if (!internalMessage || !internalUser || !internalUser._id || !internalMessage.rid) {
            return;
        }
        const federatedSender = await this.internalUserAdapter.getFederatedUserByInternalId(internalUser._id);
      Severity: Minor
      Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function sendExternalMessageReaction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public async sendExternalMessageReaction(internalMessage: IMessage, internalUser: IUser, reaction: string): Promise<void> {
        if (!internalMessage || !internalUser || !internalUser._id || !internalMessage.rid) {
            return;
        }
        const federatedSender = await this.internalUserAdapter.getFederatedUserByInternalId(internalUser._id);
      Severity: Minor
      Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return;
      Severity: Major
      Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return;
        Severity: Major
        Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return;
          Severity: Major
          Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                constructor(
        protected internalRoomAdapter: RocketChatRoomAdapter,
        protected internalUserAdapter: RocketChatUserAdapter,
        protected internalSettingsAdapter: RocketChatSettingsAdapter,
        protected internalMessageAdapter: RocketChatMessageAdapter,
            Severity: Minor
            Found in apps/meteor/server/services/federation/application/room/message/sender/MessageServiceSender.ts and 1 other location - About 55 mins to fix
            packages/ddp-client/src/DDPSDK.ts on lines 31..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status