Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts

Summary

Maintainability
C
1 day
Test Coverage

Function sendQuoteMessage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public async sendQuoteMessage(
        externalRoomId: string,
        externalSenderId: string,
        message: IMessage,
        messageToReplyTo: IMessage,
Severity: Minor
Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts - About 1 hr to fix

    Function sendMessage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public async sendMessage(externalRoomId: string, externalSenderId: string, message: IMessage): Promise<void> {
        const file = await this.internalFileHelper.getFileRecordById((message.files || [])[0]?._id);
        if (!file?.size || !file.type || !file.name) {
            return;
        }
    Severity: Minor
    Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              const externalMessageId = await this.bridge.sendMessageFileToRoom(externalRoomId, externalSenderId, buffer, {
            filename: file.name || '',
            fileSize: file.size,
            mimeType: file.type,
            metadata: {
      Severity: Major
      Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts on lines 92..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  {
                filename: file.name || '',
                fileSize: file.size,
                mimeType: file.type,
                metadata: {
      Severity: Major
      Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts on lines 60..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  {
                filename: file.name,
                fileSize: file.size,
                mimeType: file.type,
                metadata: {
      Severity: Major
      Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts on lines 189..198

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  {
                filename: file.name,
                fileSize: file.size,
                mimeType: file.type,
                metadata: {
      Severity: Major
      Found in apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/application/room/message/sender/message-sender-helper.ts on lines 231..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status