Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/domain/FederatedRoom.ts

Summary

Maintainability
B
6 hrs
Test Coverage

AbstractFederatedRoom has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

export abstract class AbstractFederatedRoom {
    protected externalId: string;

    protected internalId: string;
Severity: Minor
Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public changeDisplayRoomName(displayName: string): void {
        if (this.isDirectMessage()) {
            throw new Error('Its not possible to change a direct message name');
        }
        this.internalReference.fname = displayName;
    Severity: Major
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 55 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 95..100
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 102..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public changeRoomName(name: string): void {
        if (this.isDirectMessage()) {
            throw new Error('Its not possible to change a direct message name');
        }
        this.internalReference.name = name;
    Severity: Major
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 55 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 84..89
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 102..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public changeRoomTopic(topic: string): void {
        if (this.isDirectMessage()) {
            throw new Error('Its not possible to change a direct message topic');
        }
        this.internalReference.topic = topic;
    Severity: Major
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 55 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 84..89
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 95..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public shouldUpdateDisplayRoomName(aRoomName: string): boolean {
        return this.internalReference?.fname !== aRoomName && !this.isDirectMessage();
    }
    Severity: Minor
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 30 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 91..93
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 113..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public shouldUpdateRoomName(aRoomName: string): boolean {
        return this.internalReference?.name !== aRoomName && !this.isDirectMessage();
    }
    Severity: Minor
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 30 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 109..111
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 113..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public shouldUpdateRoomTopic(aRoomTopic: string): boolean {
        return this.internalReference?.topic !== aRoomTopic && !this.isDirectMessage();
    }
    Severity: Minor
    Found in apps/meteor/server/services/federation/domain/FederatedRoom.ts and 2 other locations - About 30 mins to fix
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 91..93
    apps/meteor/server/services/federation/domain/FederatedRoom.ts on lines 109..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status