Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/infrastructure/Factory.ts

Summary

Maintainability
D
1 day
Test Coverage

FederationFactory has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

export class FederationFactory {
    public static buildInternalSettingsAdapter(): RocketChatSettingsAdapter {
        return new RocketChatSettingsAdapter();
    }
Severity: Minor
Found in apps/meteor/server/services/federation/infrastructure/Factory.ts - About 2 hrs to fix

    Function setupListenersForLocalActions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static setupListenersForLocalActions(
        roomServiceSender: FederationRoomServiceSender,
        messageServiceSender: FederationMessageServiceSender,
    ): void {
        FederationHooks.afterUserLeaveRoom((user: IUser, room: IRoom) =>
    Severity: Minor
    Found in apps/meteor/server/services/federation/infrastructure/Factory.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static buildRoomServiceReceiver(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalMessageAdapter: RocketChatMessageAdapter,
        internalFileAdapter: RocketChatFileAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 1 other location - About 2 hrs to fix
      apps/meteor/ee/server/local-services/federation/infrastructure/Factory.ts on lines 41..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static buildMessageServiceReceiver(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalMessageAdapter: RocketChatMessageAdapter,
        internalFileAdapter: RocketChatFileAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 151..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static buildUserServiceReceiver(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalFileAdapter: RocketChatFileAdapter,
        internalNotificationAdapter: RocketChatNotificationAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 1 other location - About 1 hr to fix
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 133..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public static buildMessageServiceSender(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalSettingsAdapter: RocketChatSettingsAdapter,
        internalMessageAdapter: RocketChatMessageAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 3 other locations - About 1 hr to fix
      apps/meteor/ee/server/local-services/federation/infrastructure/Factory.ts on lines 63..77
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 107..115
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 169..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public static buildUserServiceSender(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalFileAdapter: RocketChatFileAdapter,
        internalSettingsAdapter: RocketChatSettingsAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 3 other locations - About 1 hr to fix
      apps/meteor/ee/server/local-services/federation/infrastructure/Factory.ts on lines 63..77
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 117..131
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 169..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          public static buildRoomInternalValidator(
        internalRoomAdapter: RocketChatRoomAdapter,
        internalUserAdapter: RocketChatUserAdapter,
        internalFileAdapter: RocketChatFileAdapter,
        internalSettingsAdapter: RocketChatSettingsAdapter,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 3 other locations - About 1 hr to fix
      apps/meteor/ee/server/local-services/federation/infrastructure/Factory.ts on lines 63..77
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 107..115
      apps/meteor/server/services/federation/infrastructure/Factory.ts on lines 117..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public static buildFederationBridge(internalSettingsAdapter: RocketChatSettingsAdapter, queue: InMemoryQueue): IFederationBridge {
        return new MatrixBridge(internalSettingsAdapter, queue.addToQueue.bind(queue));
    }
      Severity: Minor
      Found in apps/meteor/server/services/federation/infrastructure/Factory.ts and 1 other location - About 40 mins to fix
      apps/meteor/ee/server/local-services/federation/infrastructure/Factory.ts on lines 21..23

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status