Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts

Summary

Maintainability
F
3 days
Test Coverage

File RoomReceiver.ts has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { RoomType } from '@rocket.chat/apps-engine/definition/rooms';

import {
    FederationRoomChangeJoinRulesDto,
    FederationRoomChangeMembershipDto,
Severity: Minor
Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 4 hrs to fix

    Function createExternalRolesChangesActions has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    const createExternalRolesChangesActions = (
    currentRolesState: { [key: string]: number } = {},
    previousRolesState: { [key: string]: number } = {},
): IExternalRolesChangesToApplyInputDto => {
    const changesInRolesBasedOnPreviousState = Object.keys(previousRolesState).reduce((externalRolesChangesByUser, externalUserId) => {
    Severity: Minor
    Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createExternalRolesChangesActions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createExternalRolesChangesActions = (
    currentRolesState: { [key: string]: number } = {},
    previousRolesState: { [key: string]: number } = {},
): IExternalRolesChangesToApplyInputDto => {
    const changesInRolesBasedOnPreviousState = Object.keys(previousRolesState).reduce((externalRolesChangesByUser, externalUserId) => {
    Severity: Minor
    Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 1 hr to fix

      Function changesInRolesBasedOnPreviousState has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const changesInRolesBasedOnPreviousState = Object.keys(previousRolesState).reduce((externalRolesChangesByUser, externalUserId) => {
        const currentPowerLevel = currentRolesState[externalUserId];
        const previousPowerLevel = previousRolesState[externalUserId];
        const convertedPreviousExternalRole = convertNumericalPowerLevelToInternalRole(previousPowerLevel);
        const convertedCurrentExternalRole = convertNumericalPowerLevelToInternalRole(currentPowerLevel);
      Severity: Minor
      Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 1 hr to fix

        Function toSendRoomFileMessageDto has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static toSendRoomFileMessageDto(externalEvent: MatrixEventRoomMessageSent): FederationRoomReceiveExternalFileMessageDto {
        if (!externalEvent.content.url) {
            throw new Error('Missing url in the file message');
        }
        if (!externalEvent.content.info?.mimetype) {
        Severity: Minor
        Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 1 hr to fix

          Function toSendRoomFileMessageDto has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static toSendRoomFileMessageDto(externalEvent: MatrixEventRoomMessageSent): FederationRoomReceiveExternalFileMessageDto {
        if (!externalEvent.content.url) {
            throw new Error('Missing url in the file message');
        }
        if (!externalEvent.content.info?.mimetype) {
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      ...(isThreadedMessage
                ? {
                        thread: {
                            rootEventId: externalEvent.content?.['m.relates_to']?.event_id || '',
                            replyToEventId: externalEvent.content?.['m.relates_to']?.['m.in_reply_to']?.event_id || '',
          Severity: Major
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 4 hrs to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 285..297

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      ...(isThreadedMessage
                ? {
                        thread: {
                            rootEventId: externalEvent.content?.['m.relates_to']?.event_id || '',
                            replyToEventId: externalEvent.content?.['m.relates_to']?.['m.in_reply_to']?.event_id || '',
          Severity: Major
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 4 hrs to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 337..349

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          export const extractServerNameFromExternalIdentifier = (identifier = ''): string => {
    const splitted = identifier.split(':');

    return splitted.length > 1 ? splitted[1] : '';
};
          Severity: Major
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 1 hr to fix
          apps/meteor/server/services/federation/infrastructure/matrix/helpers/MatrixIdStringTools.ts on lines 17..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export const removeExternalSpecificCharsFromExternalIdentifier = (matrixIdentifier = ''): string => {
    return matrixIdentifier.replace('@', '').replace('!', '').replace('#', '');
};
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 50 mins to fix
          apps/meteor/server/services/federation/infrastructure/matrix/helpers/MatrixIdStringTools.ts on lines 1..3

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      externalRolesChangesForDefaultUsers[externalUserId] = isCurrentRoleAnOwner
                ? [{ action: 'add', role: ROCKET_CHAT_FEDERATION_ROLES.OWNER }]
                : [{ action: 'add', role: ROCKET_CHAT_FEDERATION_ROLES.MODERATOR }];
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 50 mins to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 165..167

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      externalRolesChangesByUser[externalUserId] = wasPreviousRoleAnOwner
                ? [{ action: 'remove', role: ROCKET_CHAT_FEDERATION_ROLES.OWNER }]
                : [{ action: 'remove', role: ROCKET_CHAT_FEDERATION_ROLES.MODERATOR }];
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 50 mins to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 144..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const externalRoomJoinRule = (
        roomState.find((stateEvent) => stateEvent.type === MatrixEventType.ROOM_JOIN_RULES_CHANGED) as MatrixEventRoomJoinRulesChanged
    )?.content?.join_rule;
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 30 mins to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 86..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const externalRoomName = (
        roomState.find((stateEvent) => stateEvent.type === MatrixEventType.ROOM_NAME_CHANGED) as MatrixEventRoomNameChanged
    )?.content?.name;
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts and 1 other location - About 30 mins to fix
          apps/meteor/server/services/federation/infrastructure/matrix/converters/room/RoomReceiver.ts on lines 102..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status