Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts

Summary

Maintainability
F
3 days
Test Coverage

File Room.ts has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { api, Message } from '@rocket.chat/core-services';
import type { IDirectMessageRoom, IRoom, IUser } from '@rocket.chat/core-typings';
import { isDirectMessageRoom } from '@rocket.chat/core-typings';
import { Rooms, Subscriptions, MatrixBridgedRoom, Users } from '@rocket.chat/models';
Severity: Minor
Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 4 hrs to fix

    RocketChatRoomAdapter has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class RocketChatRoomAdapter {
    public async getFederatedRoomByExternalId(externalRoomId: string): Promise<FederatedRoom | undefined> {
        const internalBridgedRoomId = await MatrixBridgedRoom.getLocalRoomId(externalRoomId);
        if (!internalBridgedRoomId) {
            return;
    Severity: Minor
    Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 2 hrs to fix

      Function applyRoomRolesToUser has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public async applyRoomRolesToUser({
        federatedRoom,
        fromUser,
        targetFederatedUser,
        notifyChannel,
      Severity: Major
      Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 2 hrs to fix

        Function applyRoomRolesToUser has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public async applyRoomRolesToUser({
        federatedRoom,
        fromUser,
        targetFederatedUser,
        notifyChannel,
        Severity: Minor
        Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createFederatedRoomForDirectMessage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public async createFederatedRoomForDirectMessage(federatedRoom: DirectMessageFederatedRoom): Promise<string> {
        const creatorId = federatedRoom.getCreatorId();
        const usernameOrId = federatedRoom.getCreatorUsername() || creatorId;
        if (!usernameOrId) {
            throw new Error('Cannot create a room without a creator');
        Severity: Minor
        Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 1 hr to fix

          Function addUsersToRoomWhenJoinExternalPublicRoom has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public async addUsersToRoomWhenJoinExternalPublicRoom(federatedUsers: FederatedUser[], federatedRoom: FederatedRoom): Promise<void> {
        const room = await Rooms.findOneById(federatedRoom.getInternalId());
        if (!room) {
            throw new Error('Room not found - addUsersToRoomWhenJoinExternalPublicRoom');
        }
          Severity: Minor
          Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (toRemove.length > 0) {
            const removeRolesResponse = await Subscriptions.removeRolesByUserId(uid, toRemove, rid);
            if (removeRolesResponse.modifiedCount) {
                void notifyOnSubscriptionChangedByRoomIdAndUserId(rid, uid);
            }
            Severity: Major
            Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts and 1 other location - About 4 hrs to fix
            apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts on lines 302..321

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (toAdd.length > 0) {
            const addRolesResponse = await Subscriptions.addRolesByUserId(uid, toAdd, rid);
            if (addRolesResponse.modifiedCount) {
                void notifyOnSubscriptionChangedByRoomIdAndUserId(rid, uid);
            }
            Severity: Major
            Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts and 1 other location - About 4 hrs to fix
            apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts on lines 323..342

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public async getFederatedRoomByExternalId(externalRoomId: string): Promise<FederatedRoom | undefined> {
        const internalBridgedRoomId = await MatrixBridgedRoom.getLocalRoomId(externalRoomId);
        if (!internalBridgedRoomId) {
            return;
        }
            Severity: Major
            Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts and 1 other location - About 2 hrs to fix
            apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts on lines 41..51

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public async getFederatedRoomByInternalId(internalRoomId: string): Promise<FederatedRoom | undefined> {
        const externalRoomId = await MatrixBridgedRoom.getExternalRoomId(internalRoomId);
        if (!externalRoomId) {
            return;
        }
            Severity: Major
            Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts and 1 other location - About 2 hrs to fix
            apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts on lines 30..39

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                ): {
        type: 'added' | 'removed' | 'changed';
        _id: string;
        u?: { _id: IUser['_id']; username: IUser['username']; name: IUser['name'] };
        scope?: string;
            Severity: Major
            Found in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Room.ts and 1 other location - About 2 hrs to fix
            packages/core-services/src/events/Events.ts on lines 136..141

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 88.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status