Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts

Summary

Maintainability
F
3 days
Test Coverage

Function onQueueMember has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onQueueMember(event: any): void {
        if (event.actionid !== this.actionid) {
            this.logger.error({
                msg: 'onQueueMember() Unusual behavior. ActionId does not belong to this object',
                eventActionId: event.actionid,
Severity: Minor
Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        setupEventHandlers(): void {
        // Setup necessary command event handlers based on the command
        switch (this.commandText) {
            case Commands.queue_summary.toString(): {
                this.connection.on('queuesummary', new CallbackContext(this.onQueueSummary.bind(this), this));
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 1 day to fix
    apps/meteor/server/services/voip/connector/asterisk/ami/PJSIPEndpoint.ts on lines 208..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 265.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        resetEventHandlers(): void {
        switch (this.commandText) {
            case Commands.queue_summary.toString(): {
                this.connection.off('queuesummary', this);
                this.connection.off('queuesummarycomplete', this);
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 7 hrs to fix
    apps/meteor/server/services/voip/connector/asterisk/ami/PJSIPEndpoint.ts on lines 229..247

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 178.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        onQueueStatusComplete(event: any): void {
        if (event.actionid !== this.actionid) {
            this.logger.error({
                msg: 'onQueueStatusComplete() Unusual behavior. ActionId does not belong to this object',
                eventActionId: event.actionid,
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 4 hrs to fix
    apps/meteor/server/services/voip/connector/asterisk/ami/PJSIPEndpoint.ts on lines 179..192

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 130.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        onActionResult(error: any, result: any): void {
        if (error) {
            this.logger.error({ msg: 'onActionResult()', error: JSON.stringify(error) });
            this.returnReject(`error${error} while executing command`);
        } else {
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 3 hrs to fix
    apps/meteor/server/services/voip/connector/asterisk/ami/PJSIPEndpoint.ts on lines 198..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            const queue = {
            name: event.queue,
            strategy: event.strategy,
            calls: event.calls,
            holdtime: event.holdtime,
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 1 hr to fix
    apps/meteor/app/livechat/server/api/lib/livechat.ts on lines 205..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 74.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        constructor(command: string, parametersNeeded: boolean, db: Db) {
        super(command, parametersNeeded, db);
        this._type = CommandType.AMI;
        this.logger = new Logger('ACDQueue');
    }
    Severity: Major
    Found in apps/meteor/server/services/voip/connector/asterisk/ami/ACDQueue.ts and 1 other location - About 1 hr to fix
    apps/meteor/server/services/voip/connector/asterisk/ami/ContinuousMonitor.ts on lines 59..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status