Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/settings/oauth.ts

Summary

Maintainability
F
1 wk
Test Coverage

Function createOauthSettings has 418 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    settingsRegistry.addGroup('OAuth', async function () {
        await this.section('Drupal', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Drupal',
                value: true,
Severity: Major
Found in apps/meteor/server/settings/oauth.ts - About 2 days to fix

    File oauth.ts has 422 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { settingsRegistry } from '../../app/settings/server';

export const createOauthSettings = () =>
    settingsRegistry.addGroup('OAuth', async function () {
        await this.section('Drupal', async function () {
    Severity: Minor
    Found in apps/meteor/server/settings/oauth.ts - About 6 hrs to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('Twitter', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Twitter',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 283..306
      apps/meteor/server/settings/oauth.ts on lines 307..330
      apps/meteor/server/settings/oauth.ts on lines 331..354
      apps/meteor/server/settings/oauth.ts on lines 355..378
      apps/meteor/server/settings/oauth.ts on lines 379..402

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('Facebook', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Facebook',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 307..330
      apps/meteor/server/settings/oauth.ts on lines 331..354
      apps/meteor/server/settings/oauth.ts on lines 355..378
      apps/meteor/server/settings/oauth.ts on lines 379..402
      apps/meteor/server/settings/oauth.ts on lines 403..426

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('GitHub', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Github',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 283..306
      apps/meteor/server/settings/oauth.ts on lines 307..330
      apps/meteor/server/settings/oauth.ts on lines 355..378
      apps/meteor/server/settings/oauth.ts on lines 379..402
      apps/meteor/server/settings/oauth.ts on lines 403..426

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('Google', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Google',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 283..306
      apps/meteor/server/settings/oauth.ts on lines 331..354
      apps/meteor/server/settings/oauth.ts on lines 355..378
      apps/meteor/server/settings/oauth.ts on lines 379..402
      apps/meteor/server/settings/oauth.ts on lines 403..426

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('Linkedin', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Linkedin',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 283..306
      apps/meteor/server/settings/oauth.ts on lines 307..330
      apps/meteor/server/settings/oauth.ts on lines 331..354
      apps/meteor/server/settings/oauth.ts on lines 379..402
      apps/meteor/server/settings/oauth.ts on lines 403..426

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              await this.section('Meteor', async function () {
            const enableQuery = {
                _id: 'Accounts_OAuth_Meteor',
                value: true,
            };
      Severity: Major
      Found in apps/meteor/server/settings/oauth.ts and 5 other locations - About 5 hrs to fix
      apps/meteor/server/settings/oauth.ts on lines 283..306
      apps/meteor/server/settings/oauth.ts on lines 307..330
      apps/meteor/server/settings/oauth.ts on lines 331..354
      apps/meteor/server/settings/oauth.ts on lines 355..378
      apps/meteor/server/settings/oauth.ts on lines 403..426

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 149.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status