RocketChat/Rocket.Chat

View on GitHub
apps/meteor/server/ufs/ufs-server.ts

Summary

Maintainability
D
2 days
Test Coverage

Avoid deeply nested control flow statements.
Open

                    if (req.headers['if-none-match']) {
                        if (file.etag === req.headers['if-none-match']) {
                            res.writeHead(304); // Not Modified
                            res.end();
                            return;
Severity: Major
Found in apps/meteor/server/ufs/ufs-server.ts - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if (req.headers['if-modified-since']) {
                            const modifiedSince = new Date(req.headers['if-modified-since']);
    
                            if (
                                (file.modifiedAt instanceof Date && file.modifiedAt > modifiedSince) ||
    Severity: Major
    Found in apps/meteor/server/ufs/ufs-server.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if (typeof req.headers.range === 'string') {
                              const { range } = req.headers;
      
                              // Range is not valid
                              if (!range) {
      Severity: Major
      Found in apps/meteor/server/ufs/ufs-server.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if (typeof req.headers['accept-encoding'] === 'string' && (!file.type || !/^(audio|video)/.test(file.type))) {
                                const accept = req.headers['accept-encoding'];
        
                                // Compress with gzip
                                if (accept.match(/\bgzip\b/)) {
        Severity: Major
        Found in apps/meteor/server/ufs/ufs-server.ts - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                      return;
          Severity: Major
          Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                            return;
            Severity: Major
            Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return;
              Severity: Major
              Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return;
                Severity: Major
                Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                              return;
                  Severity: Major
                  Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                                return;
                    Severity: Major
                    Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return;
                      Severity: Major
                      Found in apps/meteor/server/ufs/ufs-server.ts - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            fs.stat(path, (err) => {
                                if (err) {
                                    // Create the temp directory
                                    mkdirp(path, { mode })
                                        .then(() => {
                        Severity: Major
                        Found in apps/meteor/server/ufs/ufs-server.ts and 1 other location - About 6 hrs to fix
                        apps/meteor/server/ufs/ufs-local.ts on lines 47..63

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 173.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                                if (accept.match(/\bgzip\b/)) {
                                                    headers['Content-Encoding'] = 'gzip';
                                                    delete headers['Content-Length'];
                                                    res.writeHead(status, headers);
                                                    ws.pipe(zlib.createGzip()).pipe(res);
                        Severity: Major
                        Found in apps/meteor/server/ufs/ufs-server.ts and 1 other location - About 1 hr to fix
                        apps/meteor/server/ufs/ufs-server.ts on lines 274..280

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 63.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                                if (accept.match(/\bdeflate\b/)) {
                                                    headers['Content-Encoding'] = 'deflate';
                                                    delete headers['Content-Length'];
                                                    res.writeHead(status, headers);
                                                    ws.pipe(zlib.createDeflate()).pipe(res);
                        Severity: Major
                        Found in apps/meteor/server/ufs/ufs-server.ts and 1 other location - About 1 hr to fix
                        apps/meteor/server/ufs/ufs-server.ts on lines 266..272

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 63.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        ws.on('error', (err) => {
                                            store.onReadError.call(store, err, fileId, file);
                                            res.end();
                                        });
                        Severity: Minor
                        Found in apps/meteor/server/ufs/ufs-server.ts and 1 other location - About 35 mins to fix
                        apps/meteor/server/ufs/ufs-server.ts on lines 243..246

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 46.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        rs.on('error', (err) => {
                                            store.onReadError.call(store, err, fileId, file);
                                            res.end();
                                        });
                        Severity: Minor
                        Found in apps/meteor/server/ufs/ufs-server.ts and 1 other location - About 35 mins to fix
                        apps/meteor/server/ufs/ufs-server.ts on lines 247..250

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 46.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status