Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
ee/apps/ddp-streamer/src/DDPStreamer.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function created has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async created(): Promise<void> {
        if (!this.context) {
            return;
        }
Severity: Major
Found in ee/apps/ddp-streamer/src/DDPStreamer.ts - About 2 hrs to fix

    Function started has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async started(): Promise<void> {
        // TODO this call creates a dependency to MeteorService, should it be a hard dependency? or can this call fail and be ignored?
        try {
            const versions = await MeteorService.getAutoUpdateClientVersions();
    Severity: Minor
    Found in ee/apps/ddp-streamer/src/DDPStreamer.ts - About 1 hr to fix

      Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor(notifications: NotificationsModule) {
        super();

        new ListenersModule(this, notifications);
      Severity: Minor
      Found in ee/apps/ddp-streamer/src/DDPStreamer.ts - About 1 hr to fix

        Function started has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async started(): Promise<void> {
        // TODO this call creates a dependency to MeteorService, should it be a hard dependency? or can this call fail and be ignored?
        try {
            const versions = await MeteorService.getAutoUpdateClientVersions();
        Severity: Minor
        Found in ee/apps/ddp-streamer/src/DDPStreamer.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status