Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
ee/packages/license/__tests__/emitter.spec.ts

Summary

Maintainability
F
3 days
Test Coverage

File emitter.spec.ts has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @jest-environment node
 */

import { MockedLicenseBuilder, getReadyLicenseManager } from './MockedLicenseBuilder';
Severity: Minor
Found in ee/packages/license/__tests__/emitter.spec.ts - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should emit `behaviorToggled:prevent_action` event when the limit is reached once but `behavior:prevent_action` twice', async () => {
            const licenseManager = await getReadyLicenseManager();
            const fn = jest.fn();
            const toggleFn = jest.fn();
    Severity: Major
    Found in ee/packages/license/__tests__/emitter.spec.ts and 1 other location - About 1 day to fix
    ee/packages/license/__tests__/emitter.spec.ts on lines 221..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 284.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should emit `behaviorToggled:allow_action` event when the limit is not reached once but `behavior:allow_action` twice', async () => {
            const licenseManager = await getReadyLicenseManager();
            const fn = jest.fn();
            const toggleFn = jest.fn();
    Severity: Major
    Found in ee/packages/license/__tests__/emitter.spec.ts and 1 other location - About 1 day to fix
    ee/packages/license/__tests__/emitter.spec.ts on lines 189..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 284.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                const license = await new MockedLicenseBuilder().withLimits('activeUsers', [
                {
                    max: 10,
                    behavior: 'prevent_action',
                },
    Severity: Major
    Found in ee/packages/license/__tests__/emitter.spec.ts and 4 other locations - About 35 mins to fix
    ee/packages/license/__tests__/emitter.spec.ts on lines 131..140
    ee/packages/license/src/license.spec.ts on lines 117..126
    ee/packages/license/src/license.spec.ts on lines 162..171
    ee/packages/license/src/license.spec.ts on lines 202..211

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

                const license = await new MockedLicenseBuilder().withLimits('activeUsers', [
                {
                    max: 10,
                    behavior: 'prevent_action',
                },
    Severity: Major
    Found in ee/packages/license/__tests__/emitter.spec.ts and 4 other locations - About 35 mins to fix
    ee/packages/license/__tests__/emitter.spec.ts on lines 157..166
    ee/packages/license/src/license.spec.ts on lines 117..126
    ee/packages/license/src/license.spec.ts on lines 162..171
    ee/packages/license/src/license.spec.ts on lines 202..211

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status