Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star

Showing 4,961 of 8,229 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/departments/average-waiting-time',
    {
        authRequired: true,
        permissionsRequired: ['view-livechat-manager'],
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts and 6 other locations - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 61..98
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 100..137
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 139..176
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 217..254
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 256..293
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 295..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 297.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/departments/total-transferred-chats',
    {
        authRequired: true,
        permissionsRequired: ['view-livechat-manager'],
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts and 6 other locations - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 61..98
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 100..137
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 139..176
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 178..215
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 256..293
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 295..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 297.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/departments/average-service-time',
    {
        authRequired: true,
        permissionsRequired: ['view-livechat-manager'],
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts and 6 other locations - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 100..137
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 139..176
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 178..215
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 217..254
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 256..293
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 295..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 297.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/departments/total-abandoned-chats',
    {
        authRequired: true,
        permissionsRequired: ['view-livechat-manager'],
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts and 6 other locations - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 61..98
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 100..137
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 139..176
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 178..215
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 217..254
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 295..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 297.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/departments/percentage-abandoned-chats',
    {
        authRequired: true,
        permissionsRequired: ['view-livechat-manager'],
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts and 6 other locations - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 61..98
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 100..137
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 139..176
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 178..215
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 217..254
apps/meteor/ee/app/livechat-enterprise/server/api/departments.ts on lines 256..293

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 297.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    findByActiveUsersExcept(searchTerm, exceptions, options, searchFields, extraQuery = [], { startsWith = false, endsWith = false } = {}) {
        if (exceptions == null) {
            exceptions = [];
        }
        if (options == null) {
Severity: Major
Found in apps/meteor/server/models/raw/Users.js and 1 other location - About 1 day to fix
apps/meteor/server/models/raw/Users.js on lines 292..333

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 294.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    findPaginatedByActiveUsersExcept(
        searchTerm,
        exceptions,
        options,
        searchFields,
Severity: Major
Found in apps/meteor/server/models/raw/Users.js and 1 other location - About 1 day to fix
apps/meteor/server/models/raw/Users.js on lines 256..290

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 294.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    getMessagesSentTotalByDate({
        start,
        end,
        options = {},
    }: {
Severity: Major
Found in apps/meteor/server/models/raw/Analytics.ts and 1 other location - About 1 day to fix
apps/meteor/server/models/raw/Analytics.ts on lines 175..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 292.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    getTotalOfRegisteredUsersByDate({
        start,
        end,
        options = {},
    }: {
Severity: Major
Found in apps/meteor/server/models/raw/Analytics.ts and 1 other location - About 1 day to fix
apps/meteor/server/models/raw/Analytics.ts on lines 67..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 292.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    handlePaste = (onUpload?: (files: (File | null)[]) => void) => async (event: ClipboardEvent) => {
        if (!event.clipboardData?.items) {
            return;
        }
Severity: Major
Found in packages/livechat/src/components/Composer/index.tsx and 1 other location - About 1 day to fix
packages/livechat/src/components/Composer/index.tsx on lines 109..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 288.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    handleDrop = (onUpload?: (files: (File | null)[]) => void) => async (event: DragEvent) => {
        if (!event.dataTransfer?.items) {
            return;
        }
Severity: Major
Found in packages/livechat/src/components/Composer/index.tsx and 1 other location - About 1 day to fix
packages/livechat/src/components/Composer/index.tsx on lines 85..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 288.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it('should emit `behaviorToggled:prevent_action` event when the limit is reached once but `behavior:prevent_action` twice', async () => {
            const licenseManager = await getReadyLicenseManager();
            const fn = jest.fn();
            const toggleFn = jest.fn();
Severity: Major
Found in ee/packages/license/__tests__/emitter.spec.ts and 1 other location - About 1 day to fix
ee/packages/license/__tests__/emitter.spec.ts on lines 221..251

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 284.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it('should emit `behaviorToggled:allow_action` event when the limit is not reached once but `behavior:allow_action` twice', async () => {
            const licenseManager = await getReadyLicenseManager();
            const fn = jest.fn();
            const toggleFn = jest.fn();
Severity: Major
Found in ee/packages/license/__tests__/emitter.spec.ts and 1 other location - About 1 day to fix
ee/packages/license/__tests__/emitter.spec.ts on lines 189..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 284.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const callEndpoint = <TMethod extends Method, TPathPattern extends PathPattern>({
    method,
    pathPattern,
    keys,
    params,
Severity: Major
Found in apps/meteor/client/providers/ServerProvider.tsx and 1 other location - About 1 day to fix
packages/livechat/src/providers/ServerProvider.tsx on lines 37..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const callEndpoint = <TMethod extends Method, TPathPattern extends PathPattern>({
            method,
            pathPattern,
            keys,
            params,
Severity: Major
Found in packages/livechat/src/providers/ServerProvider.tsx and 1 other location - About 1 day to fix
apps/meteor/client/providers/ServerProvider.tsx on lines 28..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 281.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/agents/total-service-time',
    { authRequired: true, permissionsRequired: ['view-livechat-manager'], validateParams: isLivechatAnalyticsAgentsTotalServiceTimeProps },
    {
        async get() {
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/agents.ts and 1 other location - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/agents.ts on lines 15..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 275.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

API.v1.addRoute(
    'livechat/analytics/agents/average-service-time',
    { authRequired: true, permissionsRequired: ['view-livechat-manager'], validateParams: isLivechatAnalyticsAgentsAverageServiceTimeProps },
    {
        async get() {
Severity: Major
Found in apps/meteor/ee/app/livechat-enterprise/server/api/agents.ts and 1 other location - About 1 day to fix
apps/meteor/ee/app/livechat-enterprise/server/api/agents.ts on lines 48..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 275.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should receive "changed" events after subscribe', () => {
        const handlerCallback = jest.fn();
        const readyCallback = jest.fn();
        const client = new MinimalDDPClient(() => undefined);
Severity: Major
Found in ee/packages/ddp-client/__tests__/MinimalDDPClient.spec.ts and 1 other location - About 1 day to fix
ee/packages/ddp-client/__tests__/MinimalDDPClient.spec.ts on lines 169..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 272.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should receive "added" events after subscribe', () => {
        const handlerCallback = jest.fn();
        const readyCallback = jest.fn();
        const client = new MinimalDDPClient(() => undefined);
Severity: Major
Found in ee/packages/ddp-client/__tests__/MinimalDDPClient.spec.ts and 1 other location - About 1 day to fix
ee/packages/ddp-client/__tests__/MinimalDDPClient.spec.ts on lines 215..259

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 272.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

describe('format', () => {
    it('should output id in the right format', () => {
        expect(Random.id(17)).toHaveLength(17);
        expect(Random.id(29)).toHaveLength(29);
    });
Severity: Major
Found in packages/random/src/main.server.spec.ts and 1 other location - About 1 day to fix
packages/random/src/main.client.spec.ts on lines 16..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 265.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language