Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
packages/agenda/src/Job.ts

Summary

Maintainability
C
1 day
Test Coverage

Function run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public run(): Promise<Job> {
        const definition = this.agenda.getDefinition(this.attrs.name);

        return new Promise(async (resolve, reject) => {
            this.attrs.lastRunAt = new Date();
Severity: Major
Found in packages/agenda/src/Job.ts - About 2 hrs to fix

    Function _computeFromInterval has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private _computeFromInterval(interval: string | number, previousNextRunAt: Date): void {
        const { repeatTimezone: timezone, name, _id } = this.attrs;

        debug('[%s:%s] computing next run via interval [%s]', name, _id, interval);
        const lastRun = this.dateForTimezone(this.attrs.lastRunAt || new Date(), timezone);
    Severity: Minor
    Found in packages/agenda/src/Job.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _computeFromInterval has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private _computeFromInterval(interval: string | number, previousNextRunAt: Date): void {
        const { repeatTimezone: timezone, name, _id } = this.attrs;

        debug('[%s:%s] computing next run via interval [%s]', name, _id, interval);
        const lastRun = this.dateForTimezone(this.attrs.lastRunAt || new Date(), timezone);
    Severity: Minor
    Found in packages/agenda/src/Job.ts - About 1 hr to fix

      Function jobCallback has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  const jobCallback = async (err?: Error): Promise<void> => {
                // We don't want to complete the job multiple times
                if (finished) {
                    return;
                }
      Severity: Minor
      Found in packages/agenda/src/Job.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (!this.attrs.nextRunAt || isNaN(this.attrs.nextRunAt.valueOf())) {
                this.attrs.nextRunAt = null;
                debug('[%s:%s] failed to calculate nextRunAt due to invalid repeat interval', this.attrs.name, this.attrs._id);
                this.fail('failed to calculate nextRunAt due to invalid repeat interval');
            }
        Severity: Major
        Found in packages/agenda/src/Job.ts and 1 other location - About 1 hr to fix
        packages/agenda/src/Job.ts on lines 113..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (offset === date(repeatAt, offset).valueOf()) {
            this.attrs.nextRunAt = null;
            debug('[%s:%s] failed to calculate repeatAt due to invalid format', this.attrs.name, this.attrs._id);
            this.fail('failed to calculate repeatAt time due to invalid format');
        } else if (nextDate.valueOf() === lastRun.valueOf()) {
        Severity: Major
        Found in packages/agenda/src/Job.ts and 1 other location - About 1 hr to fix
        packages/agenda/src/Job.ts on lines 99..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status