Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function fixWorkspaceVersionsBeforePublish has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

export async function fixWorkspaceVersionsBeforePublish() {
    const rawWorkspaces = await getExecOutput('yarn workspaces list --json');
    const workspaces = rawWorkspaces.stdout
        .trim()
        .split('\n')
Severity: Minor
Found in packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fixWorkspaceVersionsBeforePublish has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function fixWorkspaceVersionsBeforePublish() {
    const rawWorkspaces = await getExecOutput('yarn workspaces list --json');
    const workspaces = rawWorkspaces.stdout
        .trim()
        .split('\n')
Severity: Minor
Found in packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if (!realVersion) {
                        throw new Error(`Could not find version for workspace ${dependency}`);
                    }
    Severity: Major
    Found in packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if (semver === '*') {
                        packageJson[dependencyType][dependency] = `=${realVersion}`;
                    } else if (semver === '^') {
                        packageJson[dependencyType][dependency] = `^${realVersion}`;
                    } else if (semver === '~') {
      Severity: Major
      Found in packages/release-action/src/fixWorkspaceVersionsBeforePublish.ts - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status