Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
packages/rest-typings/src/v1/roles.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 10 locations. Consider refactoring.
Open

const roleRemoveUserFromRolePropsSchema = {
    type: 'object',
    properties: {
        username: {
            type: 'string',
Severity: Major
Found in packages/rest-typings/src/v1/roles.ts and 9 other locations - About 3 hrs to fix
packages/rest-typings/src/v1/channels/ChannelsGetAllUserMentionsByChannelProps.ts on lines 9..35
packages/rest-typings/src/v1/channels/ChannelsMessagesProps.ts on lines 11..37
packages/rest-typings/src/v1/chat.ts on lines 262..287
packages/rest-typings/src/v1/omnichannel.ts on lines 319..344
packages/rest-typings/src/v1/omnichannel.ts on lines 443..468
packages/rest-typings/src/v1/omnichannel.ts on lines 694..719
packages/rest-typings/src/v1/omnichannel.ts on lines 725..750
packages/rest-typings/src/v1/omnichannel.ts on lines 810..835
packages/rest-typings/src/v1/rooms.ts on lines 26..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

const roleAddUserToRolePropsSchema = {
    type: 'object',
    properties: {
        username: {
            type: 'string',
Severity: Major
Found in packages/rest-typings/src/v1/roles.ts and 6 other locations - About 2 hrs to fix
packages/rest-typings/src/v1/chat.ts on lines 210..231
packages/rest-typings/src/v1/chat.ts on lines 503..524
packages/rest-typings/src/v1/chat.ts on lines 535..556
packages/rest-typings/src/v1/chat.ts on lines 567..588
packages/rest-typings/src/v1/chat.ts on lines 650..671
packages/rest-typings/src/v1/rooms.ts on lines 505..526

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    '/v1/roles.getUsersInRole': {
        GET: (params: RolesGetUsersInRoleProps) => {
            users: IUserInRole[];
            total: number;
        };
Severity: Major
Found in packages/rest-typings/src/v1/roles.ts and 3 other locations - About 35 mins to fix
packages/rest-typings/src/v1/chat.ts on lines 880..885
packages/rest-typings/src/v1/chat.ts on lines 886..891
packages/rest-typings/src/v1/rooms.ts on lines 537..542

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status