Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
packages/rest-typings/src/v1/teams/index.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

interface ITeamMemberInfo {
    user: IUserInfo;
    roles?: IRole['_id'][] | null;
    createdBy: Omit<IUserInfo, 'name' | 'status'>;
    createdAt: Date;
Severity: Major
Found in packages/rest-typings/src/v1/teams/index.ts and 1 other location - About 1 hr to fix
packages/core-services/src/types/ITeamService.ts on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const isTeamPropsWithTeamId = <T extends TeamProps>(props: T): props is T & { teamId: string } => 'teamId' in props;
Severity: Major
Found in packages/rest-typings/src/v1/teams/index.ts and 1 other location - About 1 hr to fix
packages/rest-typings/src/v1/teams/index.ts on lines 51..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const isTeamPropsWithTeamName = <T extends TeamProps>(props: T): props is T & { teamName: string } => 'teamName' in props;
Severity: Major
Found in packages/rest-typings/src/v1/teams/index.ts and 1 other location - About 1 hr to fix
packages/rest-typings/src/v1/teams/index.ts on lines 53..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

interface IUserInfo {
    _id: string;
    username?: string;
    name?: string;
    status?: string;
Severity: Minor
Found in packages/rest-typings/src/v1/teams/index.ts and 1 other location - About 40 mins to fix
packages/core-services/src/types/ITeamService.ts on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    '/v1/teams.listChildren': {
        GET: (params: TeamsListChildrenProps) => PaginatedResult<{ data: IRoom[] }>;
    };
Severity: Major
Found in packages/rest-typings/src/v1/teams/index.ts and 38 other locations - About 30 mins to fix
packages/rest-typings/src/v1/channels/channels.ts on lines 42..46
packages/rest-typings/src/v1/channels/channels.ts on lines 56..60
packages/rest-typings/src/v1/channels/channels.ts on lines 133..137
packages/rest-typings/src/v1/channels/channels.ts on lines 161..165
packages/rest-typings/src/v1/customSounds.ts on lines 39..43
packages/rest-typings/src/v1/customUserStatus.ts on lines 39..43
packages/rest-typings/src/v1/dm/im.ts on lines 43..47
packages/rest-typings/src/v1/dm/im.ts on lines 59..63
packages/rest-typings/src/v1/email-inbox.ts on lines 160..162
packages/rest-typings/src/v1/federation/rooms.ts on lines 17..21
packages/rest-typings/src/v1/groups/groups.ts on lines 43..47
packages/rest-typings/src/v1/groups/groups.ts on lines 56..60
packages/rest-typings/src/v1/groups/groups.ts on lines 101..105
packages/rest-typings/src/v1/omnichannel.ts on lines 3518..3522
packages/rest-typings/src/v1/omnichannel.ts on lines 3526..3530
packages/rest-typings/src/v1/omnichannel.ts on lines 3557..3561
packages/rest-typings/src/v1/omnichannel.ts on lines 3578..3582
packages/rest-typings/src/v1/omnichannel.ts on lines 3583..3587
packages/rest-typings/src/v1/omnichannel.ts on lines 3589..3593
packages/rest-typings/src/v1/omnichannel.ts on lines 3605..3609
packages/rest-typings/src/v1/omnichannel.ts on lines 3613..3617
packages/rest-typings/src/v1/omnichannel.ts on lines 3747..3749
packages/rest-typings/src/v1/omnichannel.ts on lines 3848..3850
packages/rest-typings/src/v1/omnichannel.ts on lines 3851..3853
packages/rest-typings/src/v1/omnichannel.ts on lines 3854..3858
packages/rest-typings/src/v1/omnichannel.ts on lines 3882..3884
packages/rest-typings/src/v1/omnichannel.ts on lines 3905..3907
packages/rest-typings/src/v1/omnichannel.ts on lines 3911..3913
packages/rest-typings/src/v1/omnichannel.ts on lines 3914..3916
packages/rest-typings/src/v1/omnichannel.ts on lines 4015..4019
packages/rest-typings/src/v1/omnichannel.ts on lines 4020..4024
packages/rest-typings/src/v1/rooms.ts on lines 744..748
packages/rest-typings/src/v1/rooms.ts on lines 762..766
packages/rest-typings/src/v1/users.ts on lines 153..157
packages/rest-typings/src/v1/videoConference/index.ts on lines 33..35
packages/rest-typings/src/v1/voip.ts on lines 543..545
packages/rest-typings/src/v1/voip.ts on lines 558..560
packages/rest-typings/src/v1/voip.ts on lines 576..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    '/v1/teams.autocomplete': {
        GET: (params: { name: string }) => { teams: ITeamAutocompleteResult[] };
    };
Severity: Minor
Found in packages/rest-typings/src/v1/teams/index.ts and 1 other location - About 30 mins to fix
apps/meteor/ee/app/livechat-enterprise/server/api/units.ts on lines 13..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status